Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31585 )
Change subject: ec/google/chromeec: fix the error status passing for cbi
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31585/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31585/1//COMMIT_MSG@8
PS1, Line 8:
: google_chromeec_command() can return non-zero number (both positive
: and negative) to indicate error.
That should be fixed instead, shouldn’t it? The convention is, that errors are negative?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31585
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f0a8a61d01d942cba57036a17dd527fdbbf940c
Gerrit-Change-Number: 31585
Gerrit-PatchSet: 1
Gerrit-Owner: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 23 Feb 2019 09:23:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment