Hello Arthur Heymans, Matt DeVillier, Thomas Heijligen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/libgfxinit/+/35716
to review the following change.
Change subject: gma irl: Handle CDClk and calculate dot-clock limits ......................................................................
gma irl: Handle CDClk and calculate dot-clock limits
This one is easy, the CDClk always runs at the same fixed rate. We only have to limit dot clocks to 90% of CDClk.
Change-Id: I475a276d050f5a109b44c02ee250c9f4a9ebe863 Signed-off-by: Nico Huber nico.h@gmx.de --- M common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.adb M common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.ads 2 files changed, 20 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/16/35716/1
diff --git a/common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.adb b/common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.adb index a7b1035..42aabbd 100644 --- a/common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.adb +++ b/common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.adb @@ -51,7 +51,18 @@ Time.U_Delay (20); -- DMI latency end if;
+ Config.CDClk := Config.Default_CDClk_Freq; + Config.Max_CDClk := Config.Default_CDClk_Freq; Config.Raw_Clock := Config.Default_RawClk_Freq; end Initialize;
+ procedure Limit_Dotclocks + (Configs : in out Pipe_Configs; + CDClk_Switch : out Boolean) + is + begin + Config_Helpers.Limit_Dotclocks (Configs, Config.CDClk * 90 / 100); + CDClk_Switch := False; + end Limit_Dotclocks; + end HW.GFX.GMA.Power_And_Clocks_Ironlake; diff --git a/common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.ads b/common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.ads index fc58d75..18b9c19 100644 --- a/common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.ads +++ b/common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.ads @@ -12,10 +12,19 @@ -- GNU General Public License for more details. --
+with HW.GFX.GMA.Config_Helpers; + private package HW.GFX.GMA.Power_And_Clocks_Ironlake is
procedure Initialize;
+ procedure Limit_Dotclocks + (Configs : in out Pipe_Configs; + CDClk_Switch : out Boolean) + with + Post => Config_Helpers.Stable_FB (Configs'Old, Configs); + procedure Update_CDClk (Configs : in out Pipe_Configs) is null; + procedure Pre_All_Off is null;
procedure Post_All_Off is null;
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35716 )
Change subject: gma irl: Handle CDClk and calculate dot-clock limits ......................................................................
Patch Set 1: Verified+1
Hello Arthur Heymans, Matt DeVillier, Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/libgfxinit/+/35716
to look at the new patch set (#2).
Change subject: gma irl: Handle CDClk and calculate dot-clock limits ......................................................................
gma irl: Handle CDClk and calculate dot-clock limits
This one is easy, the CDClk always runs at the same fixed rate. We only have to limit dot clocks to 90% of CDClk.
Change-Id: I475a276d050f5a109b44c02ee250c9f4a9ebe863 Signed-off-by: Nico Huber nico.h@gmx.de --- M common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.adb M common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.ads 2 files changed, 22 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/16/35716/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35716 )
Change subject: gma irl: Handle CDClk and calculate dot-clock limits ......................................................................
Patch Set 2: Verified+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35716 )
Change subject: gma ilk: Handle CDClk and calculate dot-clock limits ......................................................................
Patch Set 3: Verified+1
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35716 )
Change subject: gma ilk: Handle CDClk and calculate dot-clock limits ......................................................................
Patch Set 4: Code-Review+1
tested on Purism Librem 15v4 w/4k display
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35716 )
Change subject: gma ilk: Handle CDClk and calculate dot-clock limits ......................................................................
Patch Set 4: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35716 )
Change subject: gma ilk: Handle CDClk and calculate dot-clock limits ......................................................................
Patch Set 4: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/libgfxinit/+/35716 )
Change subject: gma ilk: Handle CDClk and calculate dot-clock limits ......................................................................
gma ilk: Handle CDClk and calculate dot-clock limits
This one is easy, the CDClk always runs at the same fixed rate. We only have to limit dot clocks to 90% of CDClk.
Change-Id: I475a276d050f5a109b44c02ee250c9f4a9ebe863 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/libgfxinit/+/35716 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.adb M common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.ads 2 files changed, 23 insertions(+), 0 deletions(-)
Approvals: Nico Huber: Verified Matt DeVillier: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.adb b/common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.adb index a7b1035..42aabbd 100644 --- a/common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.adb +++ b/common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.adb @@ -51,7 +51,18 @@ Time.U_Delay (20); -- DMI latency end if;
+ Config.CDClk := Config.Default_CDClk_Freq; + Config.Max_CDClk := Config.Default_CDClk_Freq; Config.Raw_Clock := Config.Default_RawClk_Freq; end Initialize;
+ procedure Limit_Dotclocks + (Configs : in out Pipe_Configs; + CDClk_Switch : out Boolean) + is + begin + Config_Helpers.Limit_Dotclocks (Configs, Config.CDClk * 90 / 100); + CDClk_Switch := False; + end Limit_Dotclocks; + end HW.GFX.GMA.Power_And_Clocks_Ironlake; diff --git a/common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.ads b/common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.ads index fc58d75..00e83df 100644 --- a/common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.ads +++ b/common/ironlake/hw-gfx-gma-power_and_clocks_ironlake.ads @@ -12,10 +12,22 @@ -- GNU General Public License for more details. --
+with HW.GFX.GMA.Config_Helpers; + private package HW.GFX.GMA.Power_And_Clocks_Ironlake is
procedure Initialize;
+ procedure Limit_Dotclocks + (Configs : in out Pipe_Configs; + CDClk_Switch : out Boolean) + with + Post => + not CDClk_Switch and + Config_Helpers.Stable_FB (Configs'Old, Configs); + procedure Update_CDClk (Configs : in out Pipe_Configs) is null; + procedure Enable_CDClk is null; + procedure Pre_All_Off is null;
procedure Post_All_Off is null;
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Matt DeVillier (Code Review)
-
Nico Huber (Code Review)