Change in coreboot[master]: soc/intel/common: Add PMC Crashlog PCI driver - coreboot-gerrit

4 Oct 2021


      Attention is currently required from: Francois Toguo Fotso, Tim Wawrzynczak, Kane Chen, Karthik Ramasubramanian.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57684 )
Change subject: soc/intel/common: Add PMC Crashlog PCI driver
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/common/block/crashlog/pmc_crashlog.c:
https://review.coreboot.org/c/coreboot/+/57684/comment/9b951a0f_5471f534 
PS6, Line 233: 	copy_dwords_from_sram(table_addr, dest, crashlog_info.table.total_size);
nit - blank line between declarations and first line of code
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/57684
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc27bbdf35fcd680be224ba0a0e642c94d29bca3
Gerrit-Change-Number: 57684
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Francois Toguo Fotso francois.toguo.fotso@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Kane Chen kane.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Francois Toguo Fotso francois.toguo.fotso@intel.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Kane Chen kane.chen@intel.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Mon, 04 Oct 2021 18:04:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment