Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40555 )
Change subject: soc/intel/xeon_sp/cpx: Workaround FSP-M issues
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40555/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40555/1//COMMIT_MSG@7
PS1, Line 7: Workaround
Context: "work around" is a phrasal verb, "workaround" is the corresponding noun.
Yes. The common style in coreboot is to use statements. That means a verb is required, and it’s common to use the imperative mood, cf. see `git log --oneline`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40555
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia2529526a8724cf54377b0bd2339b04fa900815a
Gerrit-Change-Number: 40555
Gerrit-PatchSet: 1
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 Apr 2020 19:58:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment