Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel.
Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56750 )
Change subject: wifi: Add support for new SAR tables revisions
......................................................................
Patch Set 18:
(1 comment)
File src/vendorcode/google/chromeos/sar.c:
https://review.coreboot.org/c/coreboot/+/56750/comment/1ec78a3f_54ccf41b
PS17, Line 138: if (CONFIG(USE_SAR)) {
: sar_limits->sar_table->version = 0;
: sar_limits->sar_table->sar_enable = CONFIG(SAR_ENABLE);
: sar_limits->sar_table->dsar_enable = CONFIG(DSAR_ENABLE);
: sar_limits->sar_table->dsar_set_num = CONFIG_DSAR_SET_NUM;
: }
The generated .hex file size varies based on the following revision choosen in config.star […]
I think as a permanent solution it is better to add "$SAR" in the beginning of the .hex file. The check is required only if the filesize matches 119 or 81.
Let me know what you think.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56750
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08c3f321938eba04e8bcff4d87cb215422715bb2
Gerrit-Change-Number: 56750
Gerrit-PatchSet: 18
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Jamie Chen
jamie.chen@intel.com
Gerrit-CC: Janiex Tu
janiex.tu@intel.corp-partner.google.com
Gerrit-CC: Matt Chen
matt.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 26 Aug 2021 01:43:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-MessageType: comment