Attention is currently required from: Felix Singer, Maximilian Brune, Name of user not set #1005283.
Angel Pons has posted comments on this change by Name of user not set #1005283. ( https://review.coreboot.org/c/coreboot/+/79979?usp=email )
Change subject: mainboard: Add MSI MS-7788 ......................................................................
Patch Set 9:
(6 comments)
File src/mainboard/msi/ms7788/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79979/comment/430bd4b8_50f88886?usp... : PS9, Line 1: # FIXME: GPU registers may not always apply. This comment is referring to some settings that aren't present here, so you should remove it
https://review.coreboot.org/c/coreboot/+/79979/comment/189ba82b_538f98d5?usp... : PS9, Line 5: Put host_bridge, peg10 and igd here
https://review.coreboot.org/c/coreboot/+/79979/comment/30b9b6e1_89eee437?usp... : PS9, Line 8: register "docking_supported" = "0"
Why? This board isn't a laptop, right?
autoport default, it can be removed because 0 is the default value for devicetree registers (they're converted to a struct initialiser).
https://review.coreboot.org/c/coreboot/+/79979/comment/fd80c3bc_a750abfb?usp... : PS9, Line 11: register "gen3_dec" = "0x00000000" : register "gen4_dec" = "0x00000000" : register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }" These are zero as well and can be removed
https://review.coreboot.org/c/coreboot/+/79979/comment/16bc61ec_a6b8385b?usp... : PS9, Line 41: device ref sata2 off end # SATA Controller 2 Unsupported PCI device 8086:1c08 I think this device is off by default so you can remove this
https://review.coreboot.org/c/coreboot/+/79979/comment/4c074d81_600a1b34?usp... : PS9, Line 43: device ref host_bridge on end # Host bridge Host bridge : device ref peg10 on end # PEG : device ref igd on end # iGPU nit: move these above the southbridge chip (see comment above)
-
Angel Pons (Code Review)