Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42960 )
Change subject: mb/google/dedede: Create Drawcia Legacy variant ......................................................................
mb/google/dedede: Create Drawcia Legacy variant
Upcoming builds of drawcia will use 16 MiB SPI ROM. So create a legacy Drawcia variant to support the builds that use 32 MiB SPI ROM.
BUG=None TEST=Build the drawcia and drawcia_legacy variant.
Cq-Depend: TBD Change-Id: Ifb5a4778abe38a396e35963a3270b0d3cc9809e0 Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/Kconfig.name 2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/42960/1
diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index 26c369f..4322520 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -66,6 +66,7 @@ default "Boten" if BOARD_GOOGLE_BOTEN default "Dedede" if BOARD_GOOGLE_DEDEDE default "Drawcia" if BOARD_GOOGLE_DRAWCIA + default "Drawcia" if BOARD_GOOGLE_DRAWCIA_LEGACY default "Waddledoo" if BOARD_GOOGLE_WADDLEDOO default "Waddledee" if BOARD_GOOGLE_WADDLEDEE default "Wheelie" if BOARD_GOOGLE_WHEELIE @@ -91,6 +92,7 @@ default "boten" if BOARD_GOOGLE_BOTEN default "dedede" if BOARD_GOOGLE_DEDEDE default "drawcia" if BOARD_GOOGLE_DRAWCIA + default "drawcia" if BOARD_GOOGLE_DRAWCIA_LEGACY default "waddledoo" if BOARD_GOOGLE_WADDLEDOO default "waddledee" if BOARD_GOOGLE_WADDLEDEE default "wheelie" if BOARD_GOOGLE_WHEELIE diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name index 4e2a450..543675c 100644 --- a/src/mainboard/google/dedede/Kconfig.name +++ b/src/mainboard/google/dedede/Kconfig.name @@ -13,6 +13,11 @@ bool "Drawcia" select BOARD_GOOGLE_BASEBOARD_DEDEDE select BASEBOARD_DEDEDE_LAPTOP + +config BOARD_GOOGLE_DRAWCIA_LEGACY + bool "Drawcia" + select BOARD_GOOGLE_BASEBOARD_DEDEDE + select BASEBOARD_DEDEDE_LAPTOP select BOARD_ROMSIZE_KB_32768
config BOARD_GOOGLE_WADDLEDOO
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42960 )
Change subject: mb/google/dedede: Create Drawcia Legacy variant ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42960/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/42960/1/src/mainboard/google/dedede... PS1, Line 15: select BASEBOARD_DEDEDE_LAPTOP I think the drawcia here would be used by proto development now so should it be still with 32MB SPI ROM? As a result, we will have drawcia and drawcia_legacy been with 32MB in a short time until next build.
Later on, we will let drawcia here to be with 16MB when next HW version is ready but not now?
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42960 )
Change subject: mb/google/dedede: Create Drawcia Legacy variant ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42960/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/42960/1/src/mainboard/google/dedede... PS1, Line 15: select BASEBOARD_DEDEDE_LAPTOP
I think the drawcia here would be used by proto development now so should it be still with 32MB SPI […]
Marco, I think it will be easiest for everyone to understand if Drawcia legacy is always 32M, and Drawcia is always 16M.
https://review.coreboot.org/c/coreboot/+/42960/1/src/mainboard/google/dedede... PS1, Line 18: bool "Drawcia" Using the same name here seems dangerous. Maybe "Drawcia (Legacy)" or "Drawcia (32M)"
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42960 )
Change subject: mb/google/dedede: Create Drawcia Legacy variant ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42960/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/42960/1/src/mainboard/google/dedede... PS1, Line 15: select BASEBOARD_DEDEDE_LAPTOP
Marco, […]
Hmm~~ If there are more people suggested this way than please go ahead. From my point of view, it is more straightforward to say using drawcia / boten FW on newest drawcia / boten board always. And for old version of board, please use X_legacy one. But currently, proto is our newest version.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42960 )
Change subject: mb/google/dedede: Create Drawcia Legacy variant ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42960/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/42960/1/src/mainboard/google/dedede... PS1, Line 15: select BASEBOARD_DEDEDE_LAPTOP
Marco, […]
Marco, As Justin mentioned it is easier from a mental model standpoint that Drawcia is always 16M and Drawcia Legacy is 32 M.
Hello build bot (Jenkins), Furquan Shaikh, Justin TerAvest, Marco Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42960
to look at the new patch set (#2).
Change subject: mb/google/dedede: Create Drawcia Legacy variant ......................................................................
mb/google/dedede: Create Drawcia Legacy variant
Upcoming builds of drawcia will use 16 MiB SPI ROM. So create a legacy Drawcia variant to support the builds that use 32 MiB SPI ROM.
BUG=None TEST=Build the drawcia and drawcia_legacy variant.
Cq-Depend: TBD Change-Id: Ifb5a4778abe38a396e35963a3270b0d3cc9809e0 Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/Kconfig.name 2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/42960/2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42960 )
Change subject: mb/google/dedede: Create Drawcia Legacy variant ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42960/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/42960/1/src/mainboard/google/dedede... PS1, Line 15: select BASEBOARD_DEDEDE_LAPTOP
Marco, As Justin mentioned it is easier from a mental model standpoint that Drawcia is always 16M an […]
Done
https://review.coreboot.org/c/coreboot/+/42960/1/src/mainboard/google/dedede... PS1, Line 18: bool "Drawcia"
Using the same name here seems dangerous. […]
Done
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42960 )
Change subject: mb/google/dedede: Create Drawcia Legacy variant ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42960 )
Change subject: mb/google/dedede: Create Drawcia Legacy variant ......................................................................
mb/google/dedede: Create Drawcia Legacy variant
Upcoming builds of drawcia will use 16 MiB SPI ROM. So create a legacy Drawcia variant to support the builds that use 32 MiB SPI ROM.
BUG=None TEST=Build the drawcia and drawcia_legacy variant.
Cq-Depend: TBD Change-Id: Ifb5a4778abe38a396e35963a3270b0d3cc9809e0 Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42960 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Justin TerAvest teravest@chromium.org --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/Kconfig.name 2 files changed, 7 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Justin TerAvest: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index 26c369f..4322520 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -66,6 +66,7 @@ default "Boten" if BOARD_GOOGLE_BOTEN default "Dedede" if BOARD_GOOGLE_DEDEDE default "Drawcia" if BOARD_GOOGLE_DRAWCIA + default "Drawcia" if BOARD_GOOGLE_DRAWCIA_LEGACY default "Waddledoo" if BOARD_GOOGLE_WADDLEDOO default "Waddledee" if BOARD_GOOGLE_WADDLEDEE default "Wheelie" if BOARD_GOOGLE_WHEELIE @@ -91,6 +92,7 @@ default "boten" if BOARD_GOOGLE_BOTEN default "dedede" if BOARD_GOOGLE_DEDEDE default "drawcia" if BOARD_GOOGLE_DRAWCIA + default "drawcia" if BOARD_GOOGLE_DRAWCIA_LEGACY default "waddledoo" if BOARD_GOOGLE_WADDLEDOO default "waddledee" if BOARD_GOOGLE_WADDLEDEE default "wheelie" if BOARD_GOOGLE_WHEELIE diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name index 4e2a450..b74752e 100644 --- a/src/mainboard/google/dedede/Kconfig.name +++ b/src/mainboard/google/dedede/Kconfig.name @@ -13,6 +13,11 @@ bool "Drawcia" select BOARD_GOOGLE_BASEBOARD_DEDEDE select BASEBOARD_DEDEDE_LAPTOP + +config BOARD_GOOGLE_DRAWCIA_LEGACY + bool "Drawcia (Legacy)" + select BOARD_GOOGLE_BASEBOARD_DEDEDE + select BASEBOARD_DEDEDE_LAPTOP select BOARD_ROMSIZE_KB_32768
config BOARD_GOOGLE_WADDLEDOO
-
Justin TerAvest (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Marco Chen (Code Review)
-
Patrick Georgi (Code Review)