Attention is currently required from: Shelley Chen, Ravi kumar, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53902 )
Change subject: sc7280: Add PCIe RC driver in Coreboot ......................................................................
Patch Set 14:
(5 comments)
File src/soc/qualcomm/sc7280/include/soc/addressmap.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121773): https://review.coreboot.org/c/coreboot/+/53902/comment/66c54762_5c17965b PS14, Line 78: #define PCIE1_MEM_SIZE 0x1fd00000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121773): https://review.coreboot.org/c/coreboot/+/53902/comment/d1caacef_6e919259 PS14, Line 79: #define PCIE_MEM_END 0x404fffff please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121773): https://review.coreboot.org/c/coreboot/+/53902/comment/49cd4f30_1a0272c5 PS14, Line 82: #define PCIE_1_QMP_PHY 0x01C0E000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121773): https://review.coreboot.org/c/coreboot/+/53902/comment/38edffcb_ef470202 PS14, Line 86: #define PCE1_QPHY_SERDES 0x01C0E000 please, no space before tabs
File src/soc/qualcomm/sc7280/include/soc/pcie.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121773): https://review.coreboot.org/c/coreboot/+/53902/comment/f26d2676_9ccacdbc PS14, Line 168: #define PCIE_DEV_FUNC (dev, func) {(PCI_SLOT(devfn)) | (PCI_FUNC(devfn))} Macros with complex values should be enclosed in parentheses
-
build bot (Jenkins) (Code Review)