Attention is currently required from: Erik van den Bogaert, Frans Hendriks, Jan Samek, Jeremy Soller, Michael Niewöhner, Michał Żygowski, Nico Huber, Piotr Król, Reagan, Sean Rhodes, Tim Crawford.
Jonathon Hall has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/79917?usp=email )
Change subject: soc/intel/skylake: Drop redundant PcieRpEnable
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/purism/librem_skl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79917/comment/6cb388e0_9e4214eb?usp... :
PS2, Line 141: register "PcieRpEnable[4]" = "1"
Tested librem_13v2. The device tree should have pcie_rp5, not pcie_rp1. […]
I fixed librem_skl in CB:80065.
File src/mainboard/razer/blade_stealth_kbl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79917/comment/d4055f97_8a488bf5?usp... :
PS2, Line 190: device ref pcie_rp1 on end
I happen to have a very similar board (see CB:82506). You are indeed correct. […]
IIRC, it's because a PCI device has to have a function 0 so it can be enumerated. If the root port corresponding to function 0 isn't enabled, the PCH promotes the first enabled function to function 0.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79917?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f7e3e1dc6b3d8d6159bd4701e6fd90f4b0f67f4
Gerrit-Change-Number: 79917
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Jan Samek
samekh@email.cz
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Reagan
xbjfk.github@gmail.com
Gerrit-Attention: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Reagan
xbjfk.github@gmail.com
Gerrit-Attention: Jan Samek
samekh@email.cz
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Wed, 29 May 2024 13:12:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathon Hall
jonathon.hall@puri.sm
Comment-In-Reply-To: Reagan
xbjfk.github@gmail.com