[L] Change in coreboot[master]: drivers/intel/fsp2_0: Add API to convert BMP images to GOP BLT buffer - coreboot-gerrit

14 Aug 2023


      Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76921?usp=email )
Change subject: drivers/intel/fsp2_0: Add API to convert BMP images to GOP BLT buffer
......................................................................
Patch Set 10:
(1 comment)
File src/drivers/intel/fsp2_0/include/fsp/fsp_gop_blt.h:
https://review.coreboot.org/c/coreboot/+/76921/comment/ac4f49c1_f0b4d0c2 :
PS10, Line 10: (uint32_t *logo, uint32_t *logo_size,
             : 	uint32_t *blt_ptr, uint32_t *blt_size,
...
uinptr_t and size_t?
Hmm valid suggestion. I will address that.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/76921?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I992b45d65374f09498ff0cab497f7091e1e7a350
Gerrit-Change-Number: 76921
Gerrit-PatchSet: 10
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Matt DeVillier matt.devillier@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 14 Aug 2023 18:54:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment