Attention is currently required from: Eric Lai, Nick Vaccaro, Paul Menzel, Shawn Ku, Subrata Banik.
Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79173?usp=email )
Change subject: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard
......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79173/comment/ba5cf6ec_95c7d5c1 :
PS3, Line 7: DB_NONE
DB should imply Daughter Board
Done
https://review.coreboot.org/c/coreboot/+/79173/comment/601ad4ae_87f902b1 :
PS3, Line 11:
Please document the schematic version.
It's by internal discuss and no release schematic for now.
File src/mainboard/google/brya/variants/quandiso/fw_config.c:
https://review.coreboot.org/c/coreboot/+/79173/comment/6d5a3a39_180b0c75 :
PS3, Line 96: printk(BIOS_INFO, "Disable USBC1 AUX Pins.\n");
Info level messages should be more elaborate. Maybe add: … according to fw_config.
Done
https://review.coreboot.org/c/coreboot/+/79173/comment/056928cb_b666b273 :
PS3, Line 96: Pins
pins
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79173?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6f702f60c772176e80b3452bf957d10625564102
Gerrit-Change-Number: 79173
Gerrit-PatchSet: 4
Gerrit-Owner: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shawn Ku
shawnku@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Shawn Ku
shawnku@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 21 Nov 2023 01:53:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shawn Ku
shawnku@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment