Attention is currently required from: Lance Zhao, Marc Jones, Furquan Shaikh, Duncan Laurie, David Hendricks, Angel Pons. Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49286 )
Change subject: src/acpi: Add APEI EINJ support ......................................................................
Patch Set 13:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49286/comment/299f0b09_10ca204e PS2, Line 14: memeory
memory
fixed.
https://review.coreboot.org/c/coreboot/+/49286/comment/ea767206_5dc16b87 PS2, Line 19: errors via the APEI file nodes. More information on error injection is here.
check your line length in the commit message so you don't get the strange wrapping here.
fixed
Patchset:
PS13: All comments resolved.
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/49286/comment/b00ef524_b7c0a659 PS2, Line 805: acpi_einj_action_table_t default_actions[] = { : /* Action 0 */ : { : .action = BEGIN_INJECT_OP, : .instruction = WRITE_REGISTER_VALUE, : .flags = FLAG_PRESERVE, : .reg = EINJ_REG_MEMORY(), : .value = 0, : .mask = 0xFFFFFFFF : }, : /* Action 1 */ : { : .action = GET_TRIGGER_ACTION_TABLE, : .instruction = READ_REGISTER, : .flags = FLAG_IGNORE, : .reg = EINJ_REG_MEMORY(), : .value = 0x0, : .mask = 0xFFFFFFFFFFFFFFFF : }, : /* Action 2 */ : { : .action = SET_ERROR_TYPE, : .instruction = WRITE_REGISTER, : .flags = FLAG_PRESERVE, : .reg = EINJ_REG_MEMORY(), : .value = 0x0, : .mask = 0xFFFFFFFF : }, : /* Action 3 */ : { : .action = GET_ERROR_TYPE, : .instruction = READ_REGISTER, : .flags = FLAG_IGNORE, : .reg = EINJ_REG_MEMORY(), : .value = 0x0, : .mask = 0xFFFFFFFF : }, : /* Action 4 */ : { : .action = END_INJECT_OP, : .instruction = WRITE_REGISTER_VALUE, : .flags = FLAG_PRESERVE, : .reg = EINJ_REG_MEMORY(), : .value = 0x0, : .mask = 0xFFFFFFFF : }, : /* Action 5 */ : { : .action = EXECUTE_INJECT_OP, : .instruction = WRITE_REGISTER_VALUE, : .flags = FLAG_PRESERVE, : .reg = EINJ_REG_IO(), : .value = 0x9a, : .mask = 0xFFFF : }, : /* Action 6 */ : { : .action = CHECK_BUSY_STATUS, : .instruction = READ_REGISTER_VALUE, : .flags = FLAG_IGNORE, : .reg = EINJ_REG_MEMORY(), : .value = 0x1, : .mask = 0x1 : }, : /* Action 7 */ : { : .action = GET_CMD_STATUS, : .instruction = READ_REGISTER, : .flags = FLAG_PRESERVE, : .reg = EINJ_REG_MEMORY(), : .value = 0x0, : .mask = 0x1fe : }, : /* Action 8 */ : { : .action = SET_ERROT_TYPE_WITH_ADDRESS, : .instruction = WRITE_REGISTER, : .flags = FLAG_PRESERVE, : .reg = EINJ_REG_MEMORY(), : .value = 0x1, : .mask = 0xffffffff : } : };
action count could be sizeof default_actions here. […]
Fixed