Attention is currently required from: David Wu. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52887 )
Change subject: mb/google/dedede/var/metaknight: Update xhci device tree ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2: So far the approach is fine. Please configure the settings as provided in the devicetree
File src/mainboard/google/dedede/variants/metaknight/variant.c:
https://review.coreboot.org/c/coreboot/+/52887/comment/02d51ac3_5d4da5a6 PS2, Line 36: /* Set 1A HDMI configuration */ Leave USB Port A as a default configuration in the devicetree. Then you dont need to handle this case.
https://review.coreboot.org/c/coreboot/+/52887/comment/73602689_299cfdbe PS2, Line 38: /* Set LTE HDMI configuration */ Configure the settings as in the devicetree. One element in the drivers_usb_acpi_config structure (desc) is a const variable. You may need to leave it generic enough in the device tree and not touch it.
memset the config->group to 0 Configure the rest of the elements in config as in the devicetree for LTE.