Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46676 )
Change subject: mb/google/volteer/variants/delbin: Update DPTF parameters for delbin
......................................................................
Patch Set 14: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/46676/14/src/mainboard/google/volte...
File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46676/14/src/mainboard/google/volte...
PS14, Line 39: [0] = DPTF_PASSIVE(CPU, CPU, 95, 6000),
: [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 75, 6000),
: [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_0, 75, 6000)
nit: this is easier to read if each column lines up
https://review.coreboot.org/c/coreboot/+/46676/14/src/mainboard/google/volte...
PS14, Line 68:
nit: extra blank line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46676
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69aa6046fdc90a2cf59ea3a13fdb15c8bc0d29a2
Gerrit-Change-Number: 46676
Gerrit-PatchSet: 14
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Deepika Punyamurtula
deepika.punyamurtula@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Todd Broch
tbroch@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Thu, 29 Oct 2020 20:33:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment