Attention is currently required from: Matt DeVillier, Michał Żygowski, MrChromebox, Piotr Król.
Hello Michał Żygowski, MrChromebox, Piotr Król,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81310?usp=email
to look at the new patch set (#3).
Change subject: superio/ite: Add special fan vectors, unify it8722f with common ......................................................................
superio/ite: Add special fan vectors, unify it8722f with common
A number of ITE SIOs support "special fan control vectors", which effectively allow non-linear fan speed control. This is for example used by the vendor firmware of "HP Pro 3500 Series".
Because that board uses the it8779e (identifying itself as it8772f) and porting it also required functionality that is only found in the common code, the it8772f code was unified with the common code except for GPIO handling which currently lacks a sane abstraction in any codebase.
The 3VSBSW# signal can now also be disabled again which is necessary to power components down properly in SMM when entering S5.
The datasheets of the it8772e(f) and it8728f (for reference) were studied and verified against the common code, adding exceptions where needed.
Change-Id: Ic4d9d5460628e444dc20f620179b39c90dbc28c6 Signed-off-by: Joel Linn jl@conductive.de --- M src/mainboard/foxconn/g41s-k/early_init.c M src/mainboard/google/beltino/bootblock.c M src/mainboard/google/beltino/devicetree.cb M src/mainboard/google/beltino/onboard.h M src/mainboard/google/jecht/bootblock.c M src/mainboard/google/jecht/devicetree.cb M src/mainboard/google/jecht/onboard.h M src/mainboard/protectli/vault_kbl/devicetree.cb M src/mainboard/samsung/stumpy/devicetree.cb M src/mainboard/samsung/stumpy/early_init.c M src/mainboard/samsung/stumpy/smihandler.c M src/superio/ite/Makefile.mk M src/superio/ite/common/Kconfig M src/superio/ite/common/early_serial.c M src/superio/ite/common/env_ctrl.c M src/superio/ite/common/env_ctrl.h M src/superio/ite/common/env_ctrl_chip.h M src/superio/ite/common/ite.h A src/superio/ite/common/mainboard_impl.h M src/superio/ite/it8728f/Kconfig M src/superio/ite/it8772f/Kconfig M src/superio/ite/it8772f/chip.h M src/superio/ite/it8772f/early_init.c M src/superio/ite/it8772f/it8772f.h M src/superio/ite/it8772f/superio.c 25 files changed, 236 insertions(+), 337 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/81310/3