Paul Menzel (paulepanter@users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17770
-gerrit
commit 7f278f8618b0af6c52f6fd9e056baab082843187 Author: Paul Menzel paulepanter@users.sourceforge.net Date: Thu Dec 8 00:03:38 2016 +0100
ec/lenovo: Add guards to fix build errors without SMBIOS
Not selecting the Kconfig option `GENERATE_SMBIOS_TABLES` the build fails with the error below.
``` CC ramstage/ec/lenovo/h8/h8.o src/ec/lenovo/h8/h8.c:201:2: error: unknown field 'get_smbios_strings' specified in initializer .get_smbios_strings = h8_smbios_strings, ^ src/ec/lenovo/h8/h8.c:201:2: error: initialization from incompatible pointer type [-Werror] src/ec/lenovo/h8/h8.c:201:2: error: (near initialization for 'h8_dev_ops.read_resources') [-Werror] cc1: all warnings being treated as errors ```
So add the appropriate preprocessor guards to fix the build error.
Change-Id: I3baed452d422539a805c628a8c4a6a8c2a809317 Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net --- src/ec/lenovo/h8/h8.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c index cfc3938..7712687 100644 --- a/src/ec/lenovo/h8/h8.c +++ b/src/ec/lenovo/h8/h8.c @@ -183,6 +183,7 @@ u8 h8_build_id_and_function_spec_version(char *buf, u8 buf_len) return i; }
+#if IS_ENABLED(CONFIG_GENERATE_SMBIOS_TABLES) static void h8_smbios_strings(struct device *dev, struct smbios_type11 *t) { char tpec[] = "IBM ThinkPad Embedded Controller -[ ]-"; @@ -191,6 +192,7 @@ static void h8_smbios_strings(struct device *dev, struct smbios_type11 *t)
t->count = smbios_add_string(t->eos, tpec); } +#endif
static void h8_init(device_t dev) { @@ -198,7 +200,9 @@ static void h8_init(device_t dev) }
struct device_operations h8_dev_ops = { +#if IS_ENABLED(CONFIG_GENERATE_SMBIOS_TABLES) .get_smbios_strings = h8_smbios_strings, +#endif .init = h8_init, };