Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21107 )
Change subject: sb,soc/intel: Fix flashconsole on older platforms
......................................................................
Patch Set 16:
(2 comments)
Fsp_broadwell_de already uses sb/Intel/common/spi
but it doesn't compile with flashconsole enabled since CB:30506 :
Then revert it. It was merged way too early.
https://review.coreboot.org/#/c/21107/16//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/21107/16//COMMIT_MSG@11
PS16, Line 11: - sb/i82801ix: select SOUTHBRIDGE_INTEL_COMMON_SPI
: - emulation/qemu-q35: select TSC_MONOTONIC_TIMER, needed as a result
: of adding SOUTHBRIDGE_INTEL_COMMON_SPI to sb/i82801ix
: - soc/{baytrail,braswell}: include spi.c in romstage and postcar
: - soc/broadwell: include spi.c and monotonic_timer.c in bootblock,
: romstage, and postcar
Maybe split it up. Having a bullet list of independent changes
is a sign that it should be.
https://review.coreboot.org/#/c/21107/16//COMMIT_MSG@17
PS16, Line 17: - soc/fsp_{baytrail,broadwell_de}: select NO_CAR_GLOBAL_MIGRATION
This will break access to global variables after CAR teardown,
i.e. needs postcar stage.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/21107
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd3e8621fa4cb349b7e0e07118cab0380f24ff55
Gerrit-Change-Number: 21107
Gerrit-PatchSet: 16
Gerrit-Owner: Nicola Corna
nicola@corna.info
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nicola Corna
nicola@corna.info
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Youness Alaoui
snifikino@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 18 May 2019 08:42:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment