Attention is currently required from: Angel Pons, Matt DeVillier, Sean Rhodes.
Filip Brozovic has posted comments on this change by Filip Brozovic. ( https://review.coreboot.org/c/coreboot/+/86080?usp=email )
Change subject: CFR: Add version field to root struct
......................................................................
Patch Set 2:
(2 comments)
File src/commonlib/include/commonlib/cfr.h:
https://review.coreboot.org/c/coreboot/+/86080/comment/05361bbc_497cbe1a?usp... :
PS1, Line 52: 0x00010000
We can start at 0
Done
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/86080/comment/ac04ec05_06cc5fda?usp... :
PS1, Line 605: major and minor
I don't think we need a major/minor distinction. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86080?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifcb950f1bdedc0ab925f3841befb7e7001c0f7f4
Gerrit-Change-Number: 86080
Gerrit-PatchSet: 2
Gerrit-Owner: Filip Brozovic
fbrozovic@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 21 Jan 2025 11:49:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com