Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40555 )
Change subject: soc/intel/xeon_sp/cpx: Workaround FSP-M issues
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40555/1/src/soc/intel/xeon_sp/cpx/r...
File src/soc/intel/xeon_sp/cpx/romstage.c:
https://review.coreboot.org/c/coreboot/+/40555/1/src/soc/intel/xeon_sp/cpx/r...
PS1, Line 23: 0x70000
same
I think we should not try to sugar-coat this.
A hack is still a hack, even if it wrapped with bunch of #defines.
This is an issue that needs to be addressed by Intel. I'd rather this stay as an eye soring reminder that this issue must be fixed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40555
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia2529526a8724cf54377b0bd2339b04fa900815a
Gerrit-Change-Number: 40555
Gerrit-PatchSet: 1
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 Apr 2020 17:40:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-MessageType: comment