Attention is currently required from: Furquan Shaikh, Angel Pons, Subrata Banik, Patrick Rudolph. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50176 )
Change subject: soc/intel/common: Add `struct gpio_pad_table` and helpers ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
Patchset:
PS1: Nice! :-)
File src/soc/intel/common/block/include/intelblocks/gpio.h:
https://review.coreboot.org/c/coreboot/+/50176/comment/904b7b1f_3a77d567 PS1, Line 75: const struct pad_config *padcfg; : size_t length; : modifying padcfg and not adapting the lenght could (will?) lead to problems; what about making both const? otoh, it's not done for other structs as well, so... feel free to mark as resolved if you don't like that idea
https://review.coreboot.org/c/coreboot/+/50176/comment/44ace442_dc42b7c2 PS1, Line 78: (struct gpio_pad_table) this cast isn't needed
https://review.coreboot.org/c/coreboot/+/50176/comment/7b4b13f7_dfd5692d PS1, Line 81: ) when the cast gets dropped. the braces () need to be dropped, too, to make it compile