EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46614 )
Change subject: mb/google/octopus/var/fleex: Add goodix touch pad support ......................................................................
mb/google/octopus/var/fleex: Add goodix touch pad support
Add goodix touch pad as below: HWID: GXTP7288 CID:PNP0C50 I2C address:0x2C I2C speed:400Khz HID Descriptor Address:0x20
BUG=b:171351666 BRANCH=octopus TEST=build image and verify goodix touch pad working.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Idb4f8d3aff09712dcc98c8ae0c9ae30dc4049e29 --- M src/mainboard/google/octopus/variants/fleex/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/46614/1
diff --git a/src/mainboard/google/octopus/variants/fleex/overridetree.cb b/src/mainboard/google/octopus/variants/fleex/overridetree.cb index 0b81752..679b101 100644 --- a/src/mainboard/google/octopus/variants/fleex/overridetree.cb +++ b/src/mainboard/google/octopus/variants/fleex/overridetree.cb @@ -128,6 +128,15 @@ register "probed" = "1" device i2c 15 on end end + chip drivers/i2c/hid + register "generic.hid" = ""GXTP7288"" + register "generic.desc" = ""Goodix Touchpad"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_135_IRQ)" + register "generic.wake" = "GPE0_DW3_27" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 2c on end + end end # - I2C 6 device pci 17.3 on chip drivers/i2c/generic
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46614 )
Change subject: mb/google/octopus/var/fleex: Add goodix touch pad support ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46614/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46614/1//COMMIT_MSG@11 PS1, Line 11: CID:PNP0C50 : I2C address:0x2C : I2C speed:400Khz : HID Descriptor Address:0x20 Please add a space after the colons.
Hello build bot (Jenkins), Henry Sun, Marco Chen, Marco Chen, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46614
to look at the new patch set (#2).
Change subject: mb/google/octopus/var/fleex: Add goodix touch pad support ......................................................................
mb/google/octopus/var/fleex: Add goodix touch pad support
Add goodix touch pad as below: HWID : GXTP7288 CID : PNP0C50 I2C address : 0x2C I2C speed : 400Khz HID Descriptor Address : 0x20
BUG=b:171351666 BRANCH=octopus TEST=build image and verify goodix touch pad working.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Idb4f8d3aff09712dcc98c8ae0c9ae30dc4049e29 --- M src/mainboard/google/octopus/variants/fleex/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/46614/2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46614 )
Change subject: mb/google/octopus/var/fleex: Add goodix touch pad support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46614/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46614/1//COMMIT_MSG@11 PS1, Line 11: CID:PNP0C50 : I2C address:0x2C : I2C speed:400Khz : HID Descriptor Address:0x20
Please add a space after the colons.
Done
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46614 )
Change subject: mb/google/octopus/var/fleex: Add goodix touch pad support ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46614 )
Change subject: mb/google/octopus/var/fleex: Add goodix touch pad support ......................................................................
mb/google/octopus/var/fleex: Add goodix touch pad support
Add goodix touch pad as below: HWID : GXTP7288 CID : PNP0C50 I2C address : 0x2C I2C speed : 400Khz HID Descriptor Address : 0x20
BUG=b:171351666 BRANCH=octopus TEST=build image and verify goodix touch pad working.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Idb4f8d3aff09712dcc98c8ae0c9ae30dc4049e29 Reviewed-on: https://review.coreboot.org/c/coreboot/+/46614 Reviewed-by: Marco Chen marcochen@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/variants/fleex/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Marco Chen: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/fleex/overridetree.cb b/src/mainboard/google/octopus/variants/fleex/overridetree.cb index 0b81752..679b101 100644 --- a/src/mainboard/google/octopus/variants/fleex/overridetree.cb +++ b/src/mainboard/google/octopus/variants/fleex/overridetree.cb @@ -128,6 +128,15 @@ register "probed" = "1" device i2c 15 on end end + chip drivers/i2c/hid + register "generic.hid" = ""GXTP7288"" + register "generic.desc" = ""Goodix Touchpad"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_135_IRQ)" + register "generic.wake" = "GPE0_DW3_27" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 2c on end + end end # - I2C 6 device pci 17.3 on chip drivers/i2c/generic
-
EricR Lai (Code Review) -
Marco Chen (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)