Attention is currently required from: Nico Huber, Paul Menzel, Julius Werner, Jan Dabros. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57708 )
Change subject: libpayload: Add host architecture ......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS5:
These things that are not present in system libc, I guess they would need additional mocking to be testable. Is this something you have in mind for the future? Or should the arch/host code stay empty as is?
I do not have any good ideas for it right now. Sorry. I think, that we can leave arch/host empty, as this code should be mocked anyway it one wants to link it to (unit-)test payload.
Heh, this only-needs-includes is exactly what I expected after reading the first paragraph :) thanks for the elaborate answer.
I've seen you added this to the commit message, but rather incidental.
Actually, it was intentional. I added it little later :)
Shouldn't we highlight this more, that this is not about testing libpayload?
I agree.
Also the Kconfig and arch directory, should we maybe call them differently? for instance TEST or TESTMODE?
I'd stay with ARCH_HOST or similar. With TEST, we would need arch/test and include/test, which are - in my opinion - a bit misleading. Actually, include/host might be confusing too... So, how about ARCH_MOCK?
-
Jakub Czapiga (Code Review)