Change in coreboot[master]: [RFC] ChromeOS: Add DECLARE_x_CROS_GPIOS() - coreboot-gerrit

4 Nov 2021


      Attention is currently required from: Nick Vaccaro, Kyösti Mälkki, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58899 )
Change subject: [RFC] ChromeOS: Add DECLARE_x_CROS_GPIOS()
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4: 
It is boilerplate, but it's also only a few lines, and this means generating a function with a macro... I don't know if it's worth it?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58899
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88406fa1b54312616e6717af3d924436dc4ff1a6
Gerrit-Change-Number: 58899
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Thu, 04 Nov 2021 14:35:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment