[S] Change in coreboot[main]: superio/smsc/sch5545/acpi/superio.asl: Clear PME status bits on SCI - coreboot-gerrit

16 Oct 2023


      Attention is currently required from: Michał Żygowski.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78351?usp=email )
Change subject: superio/smsc/sch5545/acpi/superio.asl: Clear PME status bits on SCI
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/superio/smsc/sch5545/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/78351/comment/46abc9f9_d3d4b6e6 :
PS1, Line 380: 			Notify (UAR1, 0x02) // Device Wake
...
Since this assumes existence of UAR1, shouldn't it be guarded by `#ifdef SCH5545_SHOW_UARTA`? Simila […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/78351?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I64e03d268138a62b46084be41343ef7fb089dfc3
Gerrit-Change-Number: 78351
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Krystian Hebel krystian.hebel@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Comment-Date: Mon, 16 Oct 2023 15:18:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Krystian Hebel krystian.hebel@3mdeb.com
Gerrit-MessageType: comment