Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23434 )
Change subject: nb/intel/gm45: Use parallel MP init ......................................................................
Patch Set 46: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/23434/46/src/cpu/intel/model_1067x/mp_init.c File src/cpu/intel/model_1067x/mp_init.c:
https://review.coreboot.org/#/c/23434/46/src/cpu/intel/model_1067x/mp_init.c... PS46, Line 28: static void pre_mp_init(void) That function looks familiar from other commits. Is that something that could end up in common code?
https://review.coreboot.org/#/c/23434/46/src/cpu/intel/model_6fx/model_6fx_i... File src/cpu/intel/model_6fx/model_6fx_init.c:
https://review.coreboot.org/#/c/23434/46/src/cpu/intel/model_6fx/model_6fx_i... PS46, Line 136: if (!IS_ENABLED(CONFIG_PARALLEL_MP)) when can we get rid of these decisions and have just one boot flow?
-
Patrick Georgi (Code Review)