Attention is currently required from: Tarun Tuli, Frank Chu.
Shun-min Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70232 )
Change subject: mb/google/brya/var/marasov: Adjust I2C speed ......................................................................
Patch Set 1:
(5 comments)
File src/mainboard/google/brya/variants/marasov/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/70232/comment/a97d7cf6_433d476b PS1, Line 38: I2C_SPEED_FAST The speed of these I2C buses has not changed. Please clarify the purpose of the CL.
https://review.coreboot.org/c/coreboot/+/70232/comment/a22dcf9e_ce18478e PS1, Line 39: .rise_time_ns = 650, : .fall_time_ns = 400, : .data_hold_time_ns = 50, Please provide justification for these values.
https://review.coreboot.org/c/coreboot/+/70232/comment/5aff0034_c56428c1 PS1, Line 46: .rise_time_ns = 600, : .fall_time_ns = 400, : .data_hold_time_ns = 50 Please provide justification for these values.
https://review.coreboot.org/c/coreboot/+/70232/comment/00389c6f_64893f13 PS1, Line 52: .rise_time_ns = 650, : .fall_time_ns = 400, : .data_hold_time_ns = 50, Please provide justification for these values.
https://review.coreboot.org/c/coreboot/+/70232/comment/c0fb2c9c_f22d3d62 PS1, Line 58: .rise_time_ns = 650, : .fall_time_ns = 400, : .data_hold_time_ns = 50, Please provide justification for these values.
-
Shun-min Yang (Code Review)