Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33010
Change subject: nb/intel/pineview: Use MTRR as a proxy for proper reset ......................................................................
nb/intel/pineview: Use MTRR as a proxy for proper reset
On reset this platform can sometimes hang. This also fixes pineview mainboards not building due to the symbol 'check_mtrr' lacking.
Change-Id: I61fe77113004ea664522bda549240a33e3742a98 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/pineview/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/33010/1
diff --git a/src/northbridge/intel/pineview/Makefile.inc b/src/northbridge/intel/pineview/Makefile.inc index c72fe3e..989a5ae 100644 --- a/src/northbridge/intel/pineview/Makefile.inc +++ b/src/northbridge/intel/pineview/Makefile.inc @@ -16,6 +16,7 @@
ifeq ($(CONFIG_NORTHBRIDGE_INTEL_PINEVIEW),y)
+bootblock-y += ../../x86/early_reset.S bootblock-y += bootblock.c
ramstage-y += ram_calc.c
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33010 )
Change subject: nb/intel/pineview: Use MTRR as a proxy for proper reset ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33010/1/src/northbridge/intel/pineview/Makef... File src/northbridge/intel/pineview/Makefile.inc:
https://review.coreboot.org/#/c/33010/1/src/northbridge/intel/pineview/Makef... PS1, Line 19: ../../ Moar dots needed? (resolves to "src/northbridge/x86/early_reset.S")
Hello build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33010
to look at the new patch set (#2).
Change subject: nb/intel/pineview: Use MTRR as a proxy for proper reset ......................................................................
nb/intel/pineview: Use MTRR as a proxy for proper reset
On reset this platform can sometimes hang. This also fixes pineview mainboards not building due to the symbol 'check_mtrr' lacking.
Change-Id: I61fe77113004ea664522bda549240a33e3742a98 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/pineview/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/33010/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33010 )
Change subject: nb/intel/pineview: Use MTRR as a proxy for proper reset ......................................................................
Patch Set 2: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33010 )
Change subject: nb/intel/pineview: Use MTRR as a proxy for proper reset ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33010 )
Change subject: nb/intel/pineview: Use MTRR as a proxy for proper reset ......................................................................
nb/intel/pineview: Use MTRR as a proxy for proper reset
On reset this platform can sometimes hang. This also fixes pineview mainboards not building due to the symbol 'check_mtrr' lacking.
Change-Id: I61fe77113004ea664522bda549240a33e3742a98 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/33010 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/northbridge/intel/pineview/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/northbridge/intel/pineview/Makefile.inc b/src/northbridge/intel/pineview/Makefile.inc index c72fe3e..2d16613 100644 --- a/src/northbridge/intel/pineview/Makefile.inc +++ b/src/northbridge/intel/pineview/Makefile.inc @@ -16,6 +16,7 @@
ifeq ($(CONFIG_NORTHBRIDGE_INTEL_PINEVIEW),y)
+bootblock-y += ../../../cpu/x86/early_reset.S bootblock-y += bootblock.c
ramstage-y += ram_calc.c
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)