Attention is currently required from: Angel Pons, Boris Mittelberg, Caveh Jalali, Cliff Huang, Hung-Te Lin, Jérémy Compostella, Lance Zhao, Martin L Roth, Philipp Hug, Sean Rhodes, Tim Wawrzynczak, Yidi Lin, Yu-Ping Wu, ron minnich.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78833?usp=email )
Change subject: DNS: Example of clang format
......................................................................
Patch Set 4:
(5 comments)
Patchset:
PS4:
this is definitely an improvement compared to how the result of the last attempt of auto-formatting the source code looked. not perfect, but this makes me a bit more confident that eventually deploying this might be a good idea
File src/drivers/intel/gma/i915_reg.h:
PS4:
the removed 2 space indentations make this more difficult to read
File src/drivers/pc80/vga/vga_font_8x16.c:
PS4:
this makes this file much worse than before. not sure why things work in the other files while making quite a mess here
File src/include/device/pci_ids.h:
PS4:
i'd say that this looked better before the change
File src/northbridge/intel/gm45/raminit.c:
https://review.coreboot.org/c/coreboot/+/78833/comment/55fe548b_a0b188b4 :
PS4, Line 942: /* VCO 3200 */
would moving the comments after the array elements make things to work better?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78833?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I596ec6d69184594870d9db1488618225a1ac421f
Gerrit-Change-Number: 78833
Gerrit-PatchSet: 4
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Fri, 17 Nov 2023 12:24:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment