Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29661 )
Change subject: {drivers,mb,soc/intel/braswell}: Add support for Braswell FSP MR2
......................................................................
Patch Set 8:
Patch Set 5:
Usage of 'old non MR2 fields should be moved to 'Braswell' mainboards.
but the current header is newer than MR2 (1.1.7.0 v 1.1.4.1). and since all existing boards compile with it, seems like MR2 should be the special case/exception requiring manual selection
Um, how about always selecting the respective case:
select SOC_INTEL_BRASWELL__BSWFSP_
or
select SOC_INTEL_BRASWELL_BSWSBFSP
I've also opened a ticket
https://github.com/IntelFsp/FSP/issues/14
We should at least ask for an update, shouldn't we :)
Have upload new patch. No config is used, but developer can specify the location of the FspUpdVpd.h.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29661
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id40b5d46ddda93845d9739b56aaf7ad24ee89246
Gerrit-Change-Number: 29661
Gerrit-PatchSet: 8
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 04 Apr 2019 08:27:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment