David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29744 )
Change subject: util/cbfstool: Add optional argument ibb ......................................................................
Patch Set 22: Code-Review-1
(3 comments)
Hi Patrick, Thanks for doing this. I don't think it will work as written, though - You still need a `val` in the long_options[] entry so that getopt_long() will return a value to process in the switch statement. I've added some comments as an example.
https://review.coreboot.org/c/coreboot/+/29744/20/util/cbfstool/cbfstool.c File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/29744/20/util/cbfstool/cbfstool.c@1... PS20, Line 1300: enum { /* begin after ASCII characters */ LONGOPT_IBB = 256, };
https://review.coreboot.org/c/coreboot/+/29744/20/util/cbfstool/cbfstool.c@1... PS20, Line 1678: break; You still need this, but with the int for the longopt (i.e. LONGOPT_IBB)
https://review.coreboot.org/c/coreboot/+/29744/22/util/cbfstool/cbfstool.c File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/29744/22/util/cbfstool/cbfstool.c@1... PS22, Line 1334: 0 LONGOPT_IBB
-
David Hendricks (Code Review)