Attention is currently required from: Furquan Shaikh, Henry Sun, Tao Xia, Karthikeyan Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54249 )
Change subject: mb/google/dedede/var/blipper: Configure I2C times for touchpad/touchpanel/Codec
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54249/comment/774fe356_b0663c98
PS1, Line 7: Codec
codec
https://review.coreboot.org/c/coreboot/+/54249/comment/b17b115e_be8542f8
PS1, Line 13: touchpad:387 kHz
: touchpanel:388 kHz
: audio codec RT5682:391 kHz
Please add a space after the colon (:).
https://review.coreboot.org/c/coreboot/+/54249/comment/92f94716_ae52d1fc
PS1, Line 19: 400kHz
400 kHz
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54249
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8438e37be49f8a74f53fd8460110dac1a3f06993
Gerrit-Change-Number: 54249
Gerrit-PatchSet: 1
Gerrit-Owner: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ginger Zhang
zhangqingchun@huaqin.corp-partner.google.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-CC: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Comment-Date: Sun, 16 May 2021 11:03:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment