Change in coreboot[master]: util/release: Add amd_blobs to blob list

List overview All Threads
Download

newer

older

Change in em100[master]: WIP:...

Change in coreboot[master]:...

Patrick Georgi (Code Review)

19 Nov 2019 19 Nov '19

5:19 p.m.

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36956 )

Change subject: util/release: Add amd_blobs to blob list ......................................................................

util/release: Add amd_blobs to blob list

Change-Id: I4417c733b3915ad74d81d2e1e0904da06eea300e Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/release/build-release 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/36956/1

diff --git a/util/release/build-release b/util/release/build-release index 0d90d16..e0f64ff 100755 --- a/util/release/build-release +++ b/util/release/build-release @@ -70,6 +70,7 @@ exclude_paths="3rdparty/blobs " exclude_paths+="3rdparty/fsp " exclude_paths+="3rdparty/intel-microcode " +exclude_paths+="3rdparty/amd_blobs " for i in ${exclude_paths}; do blobs_paths+="coreboot-${VERSION_NAME}/${i} " exclude_opts+="--exclude=coreboot-${VERSION_NAME}/${i} "

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Stefan Reinauer (Code Review)

22 Nov 22 Nov

10:31 p.m.

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36956 )

Change subject: util/release: Add amd_blobs to blob list ......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/36956/2/util/release/build-release File util/release/build-release:

https://review.coreboot.org/c/coreboot/+/36956/2/util/release/build-release@... PS2, Line 72: exclude_paths+="3rdparty/intel-microcode " : exclude_paths+="3rdparty/amd_blobs " unrelated, but shouldn't those live in a subtree of blobs/?

-- To view, visit https://review.coreboot.org/c/coreboot/+/36956 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4417c733b3915ad74d81d2e1e0904da06eea300e Gerrit-Change-Number: 36956 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 22 Nov 2019 21:31:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

10:48 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36956 )

Change subject: util/release: Add amd_blobs to blob list ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36956/2/util/release/build-release File util/release/build-release:

https://review.coreboot.org/c/coreboot/+/36956/2/util/release/build-release@... PS2, Line 72: exclude_paths+="3rdparty/intel-microcode " : exclude_paths+="3rdparty/amd_blobs "

...

unrelated, but shouldn't those live in a subtree of blobs/?

fsp, too? that would be some major surgery and git generally isn't too good with moving submodules around.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36956 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4417c733b3915ad74d81d2e1e0904da06eea300e Gerrit-Change-Number: 36956 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 22 Nov 2019 21:48:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-MessageType: comment

Patrick Georgi (Code Review)

26 Nov 26 Nov

5:04 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36956 )

Change subject: util/release: Add amd_blobs to blob list ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36956/2/util/release/build-release File util/release/build-release:

https://review.coreboot.org/c/coreboot/+/36956/2/util/release/build-release@... PS2, Line 72: exclude_paths+="3rdparty/intel-microcode " : exclude_paths+="3rdparty/amd_blobs "

...

fsp, too? that would be some major surgery and git generally isn't too good with moving submodules a […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/36956 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4417c733b3915ad74d81d2e1e0904da06eea300e Gerrit-Change-Number: 36956 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 26 Nov 2019 16:04:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Reinauer stefan.reinauer@coreboot.org Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

5:04 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36956 )

Change subject: util/release: Add amd_blobs to blob list ......................................................................

util/release: Add amd_blobs to blob list

Change-Id: I4417c733b3915ad74d81d2e1e0904da06eea300e Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36956 Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/release/build-release 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/36956 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4417c733b3915ad74d81d2e1e0904da06eea300e Gerrit-Change-Number: 36956 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1816

days inactive

1823

days old

coreboot-gerrit@coreboot.org

4 comments

2 participants

tags (0)

participants (2)

Patrick Georgi (Code Review)
Stefan Reinauer (Code Review)