Change in coreboot[master]: mb/google/volteer/variant/volteer: Turn I2C1 bus freq closer to 400 k...
Johnny Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43057 )
Change subject: mb/google/volteer/variant/volteer: Turn I2C1 bus freq closer to 400 kHz for Touch ......................................................................
mb/google/volteer/variant/volteer: Turn I2C1 bus freq closer to 400 kHz for Touch
The current I2C2 bus frequency is 356 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C1 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C1 frequency is 390kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I76953a9a62041779e6d8c6418073f01ec08a5d67 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/43057/1
diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb index 6549932..2f853e1 100644 --- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb @@ -188,9 +188,6 @@ }, .i2c[1] = { .speed = I2C_SPEED_FAST, - }, - .i2c[2] = { - .speed = I2C_SPEED_FAST, .speed_config[0] = { .speed = I2C_SPEED_FAST, .scl_lcnt = 163, @@ -198,6 +195,9 @@ .sda_hold = 36, }, }, + .i2c[2] = { + .speed = I2C_SPEED_FAST, + }, .i2c[3] = { .speed = I2C_SPEED_FAST, },
Johnny Li has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/43057 )
Change subject: mb/google/volteer/variant/volteer: Turn I2C1 bus freq closer to 400 kHz for Touch ......................................................................
mb/google/volteer/variant/volteer: Turn I2C1 bus freq closer to 400 kHz for Touch
The current I2C2 bus frequency is 356 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C1 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C1 frequency is 390kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I76953a9a62041779e6d8c6418073f01ec08a5d67 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/43057/2
Johnny Li has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/43057 )
Change subject: mb/google/volteer/variant/volteer: Turn I2C1 bus freq closer to 400 kHz for Touch ......................................................................
mb/google/volteer/variant/volteer: Turn I2C1 bus freq closer to 400 kHz for Touch
The current I2C2 bus frequency is 356 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C1 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C1 frequency is 390kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I76953a9a62041779e6d8c6418073f01ec08a5d67 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/43057/3
Johnny Li has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43057 )
Change subject: mb/google/volteer/variant/volteer: Turn I2C1 bus freq closer to 400 kHz for Touch ......................................................................
Abandoned
-
Johnny Li (Code Review)