Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42861 )
Change subject: soc/intel/denverton_ns: Drop smi_apmc_find_state_save() ......................................................................
soc/intel/denverton_ns: Drop smi_apmc_find_state_save()
Change-Id: I8568c29b6ef9abc423324a0c732d0efb4cbaf015 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/intel/denverton_ns/smihandler.c 1 file changed, 0 insertions(+), 37 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/42861/1
diff --git a/src/soc/intel/denverton_ns/smihandler.c b/src/soc/intel/denverton_ns/smihandler.c index 6f8faff..1ee1ba3 100644 --- a/src/soc/intel/denverton_ns/smihandler.c +++ b/src/soc/intel/denverton_ns/smihandler.c @@ -7,7 +7,6 @@ #include <console/console.h> #include <cpu/x86/cache.h> #include <cpu/x86/smm.h> -#include <cpu/intel/em64t100_save_state.h> #include <device/pci_def.h> #include <intelblocks/fast_spi.h> #include <spi-generic.h> @@ -144,42 +143,6 @@ } }
-/* - * Look for Synchronous IO SMI and use save state from that - * core in case we are not running on the same core that - * initiated the IO transaction. - */ -static __unused em64t100_smm_state_save_area_t *smi_apmc_find_state_save(uint8_t cmd) -{ - em64t100_smm_state_save_area_t *state; - int node; - - /* Check all nodes looking for the one that issued the IO */ - for (node = 0; node < CONFIG_MAX_CPUS; node++) { - state = smm_get_save_state(node); - - /* Check for Synchronous IO (bit0==1) */ - if (!(state->io_misc_info & (1 << 0))) - continue; - - /* Make sure it was a write (bit4==0) */ - if (state->io_misc_info & (1 << 4)) - continue; - - /* Check for APMC IO port */ - if (((state->io_misc_info >> 16) & 0xff) != APM_CNT) - continue; - - /* Check AX against the requested command */ - if ((state->rax & 0xff) != cmd) - continue; - - return state; - } - - return NULL; -} - static void finalize(void) { static int finalize_done;
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42861 )
Change subject: soc/intel/denverton_ns: Drop smi_apmc_find_state_save() ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42861 )
Change subject: soc/intel/denverton_ns: Drop smi_apmc_find_state_save() ......................................................................
Abandoned