Hello Edward O'Callaghan, Paul Menzel, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32887
to look at the new patch set (#3).
Change subject: Makefile: Turn off SSE instructions for x86_32 architecture ......................................................................
Makefile: Turn off SSE instructions for x86_32 architecture
Passes -no-sse to cause Clang to not generate SSE instructions when building x86_32 code.
This flag is also passed to GCC, although it appears that GCC does not generate SSE instructions. GCC is probably respecting the no-mmx and it's code generation appears unaffected.
Using GDB and QEMU, I have verified that without this patch, Clang-compiled code is failing on an SSE instruction. When the machine executes that instruction, the machine restarts. When running code compiled using -no-sse, there is no SSE instruction and booting completes.
Some other possible solutions to this problem are:
A. Drop support for x86 CPUs without SSE. (Seems unnecessary)
B. "Fix" Clang so that no-mmx implies no-sse (Will take a long time)
Signed-off-by: Alan Green avg@google.com Change-Id: Ia9e86900004a285e9a21a300894624b128e6b4d0 --- M Makefile 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/32887/3