Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49120 )
Change subject: soc/amd/picasso/root_complex: add missing set_resources ......................................................................
soc/amd/picasso/root_complex: add missing set_resources
The set_resources field in the root_complex_operations struct shouldn't be NULL, but a pointer to noop_set_resources instead. This fixes the error "PCI: 00:00.0 missing set_resources".
Change-Id: I2d9f3850b3051c92cd9c0f52f8570f4fd6133070 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/picasso/root_complex.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/49120/1
diff --git a/src/soc/amd/picasso/root_complex.c b/src/soc/amd/picasso/root_complex.c index 7ca44b0..045f30c 100644 --- a/src/soc/amd/picasso/root_complex.c +++ b/src/soc/amd/picasso/root_complex.c @@ -264,6 +264,7 @@
static struct device_operations root_complex_operations = { .read_resources = read_resources, + .set_resources = noop_set_resources, .enable_resources = pci_dev_enable_resources, .acpi_fill_ssdt = root_complex_fill_ssdt, };
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49120 )
Change subject: soc/amd/picasso/root_complex: add missing set_resources ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49120 )
Change subject: soc/amd/picasso/root_complex: add missing set_resources ......................................................................
soc/amd/picasso/root_complex: add missing set_resources
The set_resources field in the root_complex_operations struct shouldn't be NULL, but a pointer to noop_set_resources instead. This fixes the error "PCI: 00:00.0 missing set_resources".
Change-Id: I2d9f3850b3051c92cd9c0f52f8570f4fd6133070 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/49120 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/amd/picasso/root_complex.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/soc/amd/picasso/root_complex.c b/src/soc/amd/picasso/root_complex.c index 7ca44b0..045f30c 100644 --- a/src/soc/amd/picasso/root_complex.c +++ b/src/soc/amd/picasso/root_complex.c @@ -264,6 +264,7 @@
static struct device_operations root_complex_operations = { .read_resources = read_resources, + .set_resources = noop_set_resources, .enable_resources = pci_dev_enable_resources, .acpi_fill_ssdt = root_complex_fill_ssdt, };
-
Arthur Heymans (Code Review) -
Felix Held (Code Review)