Change in coreboot[master]: soc/amd/picasso: Add provision to enable/disable IOMMU - coreboot-gerrit

14 Sep 2021


      Attention is currently required from: Raul Rangel, Paul Menzel, Jason Glenesk, Felix Held.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57518 )
Change subject: soc/amd/picasso: Add provision to enable/disable IOMMU
......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/picasso/fsp_m_params.c:
https://review.coreboot.org/c/coreboot/+/57518/comment/dd5ed9d4_037b379d 
PS3, Line 114: 	mcfg->iommu_enable = is_devfn_enabled(IOMMU_DEVFN) ? CONFIG(IOMMU_ENABLE) : 0;
...
i find CONFIG(IOMMU_ENABLE) && is_devfn_enabled(IOMMU_DEVFN) much easier to read than the version us […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/57518
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id49b23963d295e62ba33afbec559bafe225ec1bf
Gerrit-Change-Number: 57518
Gerrit-PatchSet: 4
Gerrit-Owner: Aamir Bohra aamirbohra@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ritul guru ritul.bits@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk jason.glenesk@amd.corp-partner.google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 14 Sep 2021 10:26:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment