Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41753 )
Change subject: mb/intel/saddlebrook: Remove duplicated PmTimerDisabled ......................................................................
mb/intel/saddlebrook: Remove duplicated PmTimerDisabled
This option appears twice in the devicetree. Drop one instance.
Change-Id: Ib8c93665048e8fa9fcff39ca5a015cea09ceaa03 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/intel/saddlebrook/devicetree.cb 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/41753/1
diff --git a/src/mainboard/intel/saddlebrook/devicetree.cb b/src/mainboard/intel/saddlebrook/devicetree.cb index 4811a41..7c2a7d7 100644 --- a/src/mainboard/intel/saddlebrook/devicetree.cb +++ b/src/mainboard/intel/saddlebrook/devicetree.cb @@ -184,8 +184,6 @@ register "pirqg_routing" = "0x0b" register "pirqh_routing" = "0x0b"
- register "PmTimerDisabled" = "0" - register "EnableSata" = "1" register "SataSalpSupport" = "1" register "SataPortsEnable" = "{ \
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41753 )
Change subject: mb/intel/saddlebrook: Remove duplicated PmTimerDisabled ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41753 )
Change subject: mb/intel/saddlebrook: Remove duplicated PmTimerDisabled ......................................................................
mb/intel/saddlebrook: Remove duplicated PmTimerDisabled
This option appears twice in the devicetree. Drop one instance.
Change-Id: Ib8c93665048e8fa9fcff39ca5a015cea09ceaa03 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41753 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/intel/saddlebrook/devicetree.cb 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/intel/saddlebrook/devicetree.cb b/src/mainboard/intel/saddlebrook/devicetree.cb index 4811a41..7c2a7d7 100644 --- a/src/mainboard/intel/saddlebrook/devicetree.cb +++ b/src/mainboard/intel/saddlebrook/devicetree.cb @@ -184,8 +184,6 @@ register "pirqg_routing" = "0x0b" register "pirqh_routing" = "0x0b"
- register "PmTimerDisabled" = "0" - register "EnableSata" = "1" register "SataSalpSupport" = "1" register "SataPortsEnable" = "{ \
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41753 )
Change subject: mb/intel/saddlebrook: Remove duplicated PmTimerDisabled ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4246 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4245 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4244 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4243
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Nico Huber (Code Review)