Attention is currently required from: Arthur Heymans, Paul Menzel, Yu-Ping Wu, Jianjun Wang. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56793 )
Change subject: soc/mediatek/mt8195: Enable PCIe support for mt8195 ......................................................................
Patch Set 18:
(1 comment)
File src/soc/mediatek/mt8195/Kconfig:
https://review.coreboot.org/c/coreboot/+/56793/comment/7ee403ad_e81d107d PS8, Line 13: select PCIE_MEDIATEK
hungte@, do you prefer enabling PCI in mainboard Kconfig?
That really depends on how we organize the initialization.
One typical solution is - Always select the config in SoC, since it's always available - But don't do init by default in SoC folder, and leave it to the mainboard to decide if it wants to init.
On the otherhand, if there's no easy way to do that (e.g., there are lots of init steps must be done inside other init steps so we can't easily decide it from mainboard), then I'd agree to move the option into mainboard.
From the change here, I can't easily identify which is the case - will things go wrong if we select PCI, and support pci_domain_ops, but don't really enable PCI?
-
Hung-Te Lin (Code Review)