Change in coreboot[master]: nb/intel/i945: Program CxODT value for each channel - coreboot-gerrit

16 Mar 2020


      Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18548 )
Change subject: nb/intel/i945: Program CxODT value for each channel
......................................................................
Patch Set 35:
(1 comment)
https://review.coreboot.org/c/coreboot/+/18548/34/src/northbridge/intel/i945... 
File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/18548/34/src/northbridge/intel/i945... 
PS34, Line 2450: one
...
no […]
We are talking about `(populated_dimms & 3) == 1 != (populated_dimms & 3) == 2)`, right?
If `(populated_dimms & 3) == 0`, the statement above evaluates to false as `0 != 0` is not true. The value wouldn’t be written.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/18548
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7aec35f45250da554ddc5a68f5add157c313399c
Gerrit-Change-Number: 18548
Gerrit-PatchSet: 35
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Mon, 16 Mar 2020 08:54:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net
Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr
Gerrit-MessageType: comment