Arthur Heymans (arthur@aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16415
-gerrit
commit 08032ee6eddcd0fe8b8ae09ce71fea90668d7136 Author: Arthur Heymans arthur@aheymans.xyz Date: Fri Sep 2 23:14:54 2016 +0200
commonlib: move DIV_ROUND macros from nvidia/tegra
DIV_ROUND_CLOSEST and DIV_ROUND_UP are useful macros for other architectures. This patch moves them from soc/nvidia/tegra/types.h to commonlib/include/commonlib/helpers.h .
Change-Id: I54521d9b197934cef8e352f9a5c4823015d85f01 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- src/commonlib/include/commonlib/helpers.h | 16 ++++++++++++++++ src/soc/nvidia/tegra/types.h | 18 ------------------ src/soc/nvidia/tegra210/addressmap.c | 1 + src/soc/nvidia/tegra210/dsi.c | 1 + 4 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/src/commonlib/include/commonlib/helpers.h b/src/commonlib/include/commonlib/helpers.h index 0318e44..1be1fbb 100644 --- a/src/commonlib/include/commonlib/helpers.h +++ b/src/commonlib/include/commonlib/helpers.h @@ -34,6 +34,22 @@ #define ABS(a) (((a) < 0) ? (-(a)) : (a)) #define CEIL_DIV(a, b) (((a) + (b) - 1) / (b)) #define IS_POWER_OF_2(x) (((x) & ((x) - 1)) == 0) +#define DIV_ROUND_UP(x, y) (((x) + (y) - 1) / (y)) +/* + * Divide positive or negative dividend by positive divisor and round + * to closest integer. Result is undefined for negative divisors and + * for negative dividends if the divisor variable type is unsigned. + */ +#define DIV_ROUND_CLOSEST(x, divisor)( \ +{ \ + typeof(x) __x = x; \ + typeof(divisor) __d = divisor; \ + (((typeof(x))-1) > 0 || \ + ((typeof(divisor))-1) > 0 || (__x) > 0) ? \ + (((__x) + ((__d) / 2)) / (__d)) : \ + (((__x) - ((__d) / 2)) / (__d)); \ +} \ +)
/* Standard units. */ #define KiB (1<<10) diff --git a/src/soc/nvidia/tegra/types.h b/src/soc/nvidia/tegra/types.h index dab474d..bfeebae 100644 --- a/src/soc/nvidia/tegra/types.h +++ b/src/soc/nvidia/tegra/types.h @@ -51,22 +51,4 @@ (type *)( (char *)__mptr - offsetof(type,member) );}) #endif
-#define DIV_ROUND_UP(x, y) (((x) + (y) - 1) / (y)) - -/* - * Divide positive or negative dividend by positive divisor and round - * to closest integer. Result is undefined for negative divisors and - * for negative dividends if the divisor variable type is unsigned. - */ -#define DIV_ROUND_CLOSEST(x, divisor)( \ -{ \ - typeof(x) __x = x; \ - typeof(divisor) __d = divisor; \ - (((typeof(x))-1) > 0 || \ - ((typeof(divisor))-1) > 0 || (__x) > 0) ? \ - (((__x) + ((__d) / 2)) / (__d)) : \ - (((__x) - ((__d) / 2)) / (__d)); \ -} \ -) - #endif /* __TEGRA_MISC_TYPES_H__ */ diff --git a/src/soc/nvidia/tegra210/addressmap.c b/src/soc/nvidia/tegra210/addressmap.c index e803e1b..18bb081 100644 --- a/src/soc/nvidia/tegra210/addressmap.c +++ b/src/soc/nvidia/tegra210/addressmap.c @@ -15,6 +15,7 @@
#include <assert.h> #include <arch/io.h> +#include <commonlib/helpers.h> #include <console/console.h> #include <soc/addressmap.h> #include <soc/id.h> diff --git a/src/soc/nvidia/tegra210/dsi.c b/src/soc/nvidia/tegra210/dsi.c index 3b771c9..5504b4d 100644 --- a/src/soc/nvidia/tegra210/dsi.c +++ b/src/soc/nvidia/tegra210/dsi.c @@ -32,6 +32,7 @@ #include <soc/tegra_dsi.h> #include <soc/mipi-phy.h> #include "jdi_25x18_display/panel-jdi-lpm102a188a.h" +#include <commonlib/helpers.h>
struct tegra_mipi_device mipi_device_data[NUM_DSI];
-
Arthur Heymans