Attention is currently required from: Martin Roth, Furquan Shaikh, Karthik Ramasubramanian.
Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51501 )
Change subject: mb/google/dedede/var/boten: Add custom Wifi SAR for botenflex
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS5:
Hi Karthik,
In order to ensure get_wifi_sar_cbfs_filename() be executed, i modify Makefile to change variant.c from smm to ramstage. Does it will impact LTE power on/off behavior? Or i need to do this split initialization in smm and ramstage?
File src/mainboard/google/dedede/variants/boten/variant.c:
https://review.coreboot.org/c/coreboot/+/51501/comment/75202f70_e5f9053c
PS4, Line 32: 0x90000
Done
Hi Karthik,
In order to ensure get_wifi_sar_cbfs_filename() be executed, i modify Makefile to change variant.c from smm to ramstage. Does it will impact LTE power on/off behavior? Or i need to do this split initialization in smm and ramstage?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51501
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3f2529a7ad56ff306df98f77cda556656da52a5
Gerrit-Change-Number: 51501
Gerrit-PatchSet: 5
Gerrit-Owner: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Henry Sun
henrysun@google.com
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 07 Apr 2021 15:03:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment