Attention is currently required from: Felix Singer, Michał Żygowski, Angel Pons, Michael Niewöhner.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62498 )
Change subject: mb/clevo/tgl-u: Add Clevo NV4x Tiger Lake laptop support
......................................................................
Patch Set 14:
(1 comment)
File src/mainboard/clevo/tgl-u/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/62498/comment/801dd708_e173b652
PS1, Line 58: register "LpmStateDisableMask" = "
: LPM_S0i2_1 |
: LPM_S0i2_2 |
: LPM_S0i3_1 |
: LPM_S0i3_2 |
: LPM_S0i3_3 |
: LPM_S0i3_4
:
-> see Michal's and my discussion in matrix ;) Intel docs don't state any specific requirements, so […]
Understood. With the `LpmStateDisableMask` removed, s0i2.0 and s0i2.1 are enabled. Unfortunately the board doesn't reach s0i2.1 due to some IPs not turning off, but it seems to be stable otherwise
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62498
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib373d62d9d18bafdfde2e1acb4e00e3a20ae09bc
Gerrit-Change-Number: 62498
Gerrit-PatchSet: 14
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Fri, 06 May 2022 08:08:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Michał Kopeć
michal.kopec@3mdeb.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment