HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31715
Change subject: src: Drop unused include <arch/acpi.h> ......................................................................
src: Drop unused include <arch/acpi.h>
Change-Id: I1f44ffeb54955ed660162a791c6281f292b1116a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/amd/pi/00630F01/model_15_init.c M src/cpu/amd/pi/00660F01/model_15_init.c M src/cpu/amd/pi/00730F01/model_16_init.c M src/cpu/intel/haswell/romstage.c M src/cpu/x86/mtrr/mtrr.c M src/mainboard/amd/bettong/mainboard.c M src/mainboard/amd/db-ft3b-lc/mainboard.c M src/mainboard/amd/gardenia/mainboard.c M src/mainboard/amd/lamar/mainboard.c M src/mainboard/amd/olivehillplus/mainboard.c M src/mainboard/amd/thatcher/romstage.c M src/mainboard/asrock/imb-a180/romstage.c M src/mainboard/asus/kcma-d8/romstage.c M src/mainboard/asus/kgpe-d16/romstage.c M src/mainboard/asus/p5gc-mx/romstage.c M src/mainboard/bap/ode_e21XX/mainboard.c M src/mainboard/getac/p470/mainboard.c M src/mainboard/getac/p470/romstage.c M src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c M src/mainboard/intel/bayleybay_fsp/mainboard.c M src/mainboard/intel/bayleybay_fsp/romstage.c M src/mainboard/intel/camelbackmountain_fsp/mainboard.c M src/mainboard/intel/dcp847ske/early_southbridge.c M src/mainboard/intel/emeraldlake2/romstage.c M src/mainboard/intel/kblrvp/smihandler.c 25 files changed, 3 insertions(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/31715/1
diff --git a/src/cpu/amd/pi/00630F01/model_15_init.c b/src/cpu/amd/pi/00630F01/model_15_init.c index d364513..5455b0c 100644 --- a/src/cpu/amd/pi/00630F01/model_15_init.c +++ b/src/cpu/amd/pi/00630F01/model_15_init.c @@ -26,7 +26,6 @@ #include <cpu/x86/lapic.h> #include <cpu/cpu.h> #include <cpu/x86/cache.h> -#include <arch/acpi.h>
static void model_15_init(struct device *dev) { diff --git a/src/cpu/amd/pi/00660F01/model_15_init.c b/src/cpu/amd/pi/00660F01/model_15_init.c index 818cfa4..d156525 100644 --- a/src/cpu/amd/pi/00660F01/model_15_init.c +++ b/src/cpu/amd/pi/00660F01/model_15_init.c @@ -25,7 +25,6 @@ #include <cpu/x86/lapic.h> #include <cpu/cpu.h> #include <cpu/x86/cache.h> -#include <arch/acpi.h>
#include <amdlib.h> #include <PspBaseLib.h> diff --git a/src/cpu/amd/pi/00730F01/model_16_init.c b/src/cpu/amd/pi/00730F01/model_16_init.c index 9be6e2a..7ae89b4 100644 --- a/src/cpu/amd/pi/00730F01/model_16_init.c +++ b/src/cpu/amd/pi/00730F01/model_16_init.c @@ -25,7 +25,6 @@ #include <cpu/x86/lapic.h> #include <cpu/cpu.h> #include <cpu/x86/cache.h> -#include <arch/acpi.h>
static void model_16_init(struct device *dev) { diff --git a/src/cpu/intel/haswell/romstage.c b/src/cpu/intel/haswell/romstage.c index e2dd0fa..d5028c2 100644 --- a/src/cpu/intel/haswell/romstage.c +++ b/src/cpu/intel/haswell/romstage.c @@ -24,7 +24,6 @@ #include <halt.h> #include <lib.h> #include <timestamp.h> -#include <arch/acpi.h> #include <device/pci_def.h> #include <cpu/x86/lapic.h> #include <cbmem.h> diff --git a/src/cpu/x86/mtrr/mtrr.c b/src/cpu/x86/mtrr/mtrr.c index 249d631..b45d17f 100644 --- a/src/cpu/x86/mtrr/mtrr.c +++ b/src/cpu/x86/mtrr/mtrr.c @@ -33,7 +33,6 @@ #include <cpu/x86/mtrr.h> #include <cpu/x86/cache.h> #include <cpu/x86/lapic.h> -#include <arch/acpi.h> #include <memrange.h> #include <cpu/amd/mtrr.h> #include <assert.h> diff --git a/src/mainboard/amd/bettong/mainboard.c b/src/mainboard/amd/bettong/mainboard.c index 16fc47e..80b888e 100644 --- a/src/mainboard/amd/bettong/mainboard.c +++ b/src/mainboard/amd/bettong/mainboard.c @@ -15,7 +15,6 @@
#include <console/console.h> #include <device/device.h> -#include <arch/acpi.h> #include <agesawrapper.h> #include <southbridge/amd/common/amd_pci_util.h>
diff --git a/src/mainboard/amd/db-ft3b-lc/mainboard.c b/src/mainboard/amd/db-ft3b-lc/mainboard.c index d5ae995..6ea80ed 100644 --- a/src/mainboard/amd/db-ft3b-lc/mainboard.c +++ b/src/mainboard/amd/db-ft3b-lc/mainboard.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <arch/acpi.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/mainboard/amd/gardenia/mainboard.c b/src/mainboard/amd/gardenia/mainboard.c index 86dfed4..b3f2285 100644 --- a/src/mainboard/amd/gardenia/mainboard.c +++ b/src/mainboard/amd/gardenia/mainboard.c @@ -15,7 +15,6 @@
#include <console/console.h> #include <device/device.h> -#include <arch/acpi.h> #include <amdblocks/agesawrapper.h> #include <amdblocks/amd_pci_util.h> #include <soc/southbridge.h> diff --git a/src/mainboard/amd/lamar/mainboard.c b/src/mainboard/amd/lamar/mainboard.c index 08d21c8..3d33850 100644 --- a/src/mainboard/amd/lamar/mainboard.c +++ b/src/mainboard/amd/lamar/mainboard.c @@ -17,7 +17,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_def.h> -#include <arch/acpi.h> #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <northbridge/amd/pi/00630F01/pci_devs.h> diff --git a/src/mainboard/amd/olivehillplus/mainboard.c b/src/mainboard/amd/olivehillplus/mainboard.c index 45841f9..00ac1a4 100644 --- a/src/mainboard/amd/olivehillplus/mainboard.c +++ b/src/mainboard/amd/olivehillplus/mainboard.c @@ -17,7 +17,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_def.h> -#include <arch/acpi.h> #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h>
diff --git a/src/mainboard/amd/thatcher/romstage.c b/src/mainboard/amd/thatcher/romstage.c index ed22ed1..54ced88 100644 --- a/src/mainboard/amd/thatcher/romstage.c +++ b/src/mainboard/amd/thatcher/romstage.c @@ -16,7 +16,6 @@ #include <stdint.h> #include <string.h> #include <device/pci_def.h> -#include <arch/acpi.h> #include <arch/io.h> #include <device/pci_ops.h> #include <commonlib/loglevel.h> diff --git a/src/mainboard/asrock/imb-a180/romstage.c b/src/mainboard/asrock/imb-a180/romstage.c index 83fc9a0..c100a61 100644 --- a/src/mainboard/asrock/imb-a180/romstage.c +++ b/src/mainboard/asrock/imb-a180/romstage.c @@ -16,7 +16,6 @@ #include <stdint.h> #include <string.h> #include <device/pci_def.h> -#include <arch/acpi.h> #include <arch/io.h> #include <device/pci_ops.h> #include <commonlib/loglevel.h> diff --git a/src/mainboard/asus/kcma-d8/romstage.c b/src/mainboard/asus/kcma-d8/romstage.c index 028af4c..4546190 100644 --- a/src/mainboard/asus/kcma-d8/romstage.c +++ b/src/mainboard/asus/kcma-d8/romstage.c @@ -20,6 +20,7 @@ #include <stdint.h> #include <string.h> #include <device/pci_def.h> +#include <arch/acpi.h> #include <arch/io.h> #include <device/pci_ops.h> #include <arch/cpu.h> diff --git a/src/mainboard/asus/kgpe-d16/romstage.c b/src/mainboard/asus/kgpe-d16/romstage.c index 5c4dbe8..cf0d33b 100644 --- a/src/mainboard/asus/kgpe-d16/romstage.c +++ b/src/mainboard/asus/kgpe-d16/romstage.c @@ -20,6 +20,7 @@ #include <stdint.h> #include <string.h> #include <device/pci_def.h> +#include <arch/acpi.h> #include <arch/io.h> #include <device/pci_ops.h> #include <arch/cpu.h> diff --git a/src/mainboard/asus/p5gc-mx/romstage.c b/src/mainboard/asus/p5gc-mx/romstage.c index 6493809..35882b2 100644 --- a/src/mainboard/asus/p5gc-mx/romstage.c +++ b/src/mainboard/asus/p5gc-mx/romstage.c @@ -23,7 +23,6 @@ #include <device/pci_ops.h> #include <device/pci_def.h> #include <cpu/x86/lapic.h> -#include <arch/acpi.h> #include <superio/winbond/common/winbond.h> #include <superio/winbond/w83627dhg/w83627dhg.h> #include <console/console.h> diff --git a/src/mainboard/bap/ode_e21XX/mainboard.c b/src/mainboard/bap/ode_e21XX/mainboard.c index 45841f9..00ac1a4 100644 --- a/src/mainboard/bap/ode_e21XX/mainboard.c +++ b/src/mainboard/bap/ode_e21XX/mainboard.c @@ -17,7 +17,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_def.h> -#include <arch/acpi.h> #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h>
diff --git a/src/mainboard/getac/p470/mainboard.c b/src/mainboard/getac/p470/mainboard.c index 813b1d6..3b84905 100644 --- a/src/mainboard/getac/p470/mainboard.c +++ b/src/mainboard/getac/p470/mainboard.c @@ -14,6 +14,7 @@ * GNU General Public License for more details. */
+#include <arch/acpi.h> #include <device/device.h> #include <device/pci_def.h> #include <device/pci_ops.h> diff --git a/src/mainboard/getac/p470/romstage.c b/src/mainboard/getac/p470/romstage.c index dcfd27f..ec73399 100644 --- a/src/mainboard/getac/p470/romstage.c +++ b/src/mainboard/getac/p470/romstage.c @@ -20,7 +20,6 @@ #include <device/pci_ops.h> #include <device/pci_def.h> #include <cpu/x86/lapic.h> -#include <arch/acpi.h> #include <pc80/mc146818rtc.h> #include <console/console.h> #include <cpu/x86/bist.h> diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c b/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c index 4f445ab..b3ee2a8 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c @@ -21,7 +21,6 @@ #include <device/pci_ops.h> #include <device/pci_def.h> #include <cpu/x86/lapic.h> -#include <arch/acpi.h> #include <superio/ite/it8718f/it8718f.h> #include <superio/ite/common/ite.h> #include <console/console.h> diff --git a/src/mainboard/intel/bayleybay_fsp/mainboard.c b/src/mainboard/intel/bayleybay_fsp/mainboard.c index 00f5f5d..9424855 100644 --- a/src/mainboard/intel/bayleybay_fsp/mainboard.c +++ b/src/mainboard/intel/bayleybay_fsp/mainboard.c @@ -22,7 +22,6 @@ #if IS_ENABLED(CONFIG_VGA_ROM_RUN) #include <x86emu/x86emu.h> #endif -#include <arch/acpi.h> #include <arch/interrupt.h> #include <boot/coreboot_tables.h>
diff --git a/src/mainboard/intel/bayleybay_fsp/romstage.c b/src/mainboard/intel/bayleybay_fsp/romstage.c index e3deddd..7c906ce 100644 --- a/src/mainboard/intel/bayleybay_fsp/romstage.c +++ b/src/mainboard/intel/bayleybay_fsp/romstage.c @@ -24,7 +24,6 @@ #include <soc/lpc.h> #include <soc/pci_devs.h> #include <soc/romstage.h> -#include <soc/acpi.h> #include <soc/baytrail.h> #include <drivers/intel/fsp1_0/fsp_util.h>
diff --git a/src/mainboard/intel/camelbackmountain_fsp/mainboard.c b/src/mainboard/intel/camelbackmountain_fsp/mainboard.c index e73da8d..946a453 100644 --- a/src/mainboard/intel/camelbackmountain_fsp/mainboard.c +++ b/src/mainboard/intel/camelbackmountain_fsp/mainboard.c @@ -22,7 +22,6 @@ #if IS_ENABLED(CONFIG_VGA_ROM_RUN) #include <x86emu/x86emu.h> #endif -#include <arch/acpi.h> #include <arch/interrupt.h> #include <boot/coreboot_tables.h>
diff --git a/src/mainboard/intel/dcp847ske/early_southbridge.c b/src/mainboard/intel/dcp847ske/early_southbridge.c index 233800a..1a46f8b 100644 --- a/src/mainboard/intel/dcp847ske/early_southbridge.c +++ b/src/mainboard/intel/dcp847ske/early_southbridge.c @@ -21,7 +21,6 @@ #include <arch/io.h> #include <device/pci_ops.h> #include <device/pci_def.h> -#include <arch/acpi.h> #include <console/console.h> #include <northbridge/intel/sandybridge/raminit_native.h>
diff --git a/src/mainboard/intel/emeraldlake2/romstage.c b/src/mainboard/intel/emeraldlake2/romstage.c index 4074a30..d5ba961 100644 --- a/src/mainboard/intel/emeraldlake2/romstage.c +++ b/src/mainboard/intel/emeraldlake2/romstage.c @@ -21,7 +21,6 @@ #include <device/pci_ops.h> #include <device/pci_def.h> #include <cpu/x86/lapic.h> -#include <arch/acpi.h> #include <superio/smsc/sio1007/chip.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit.h> diff --git a/src/mainboard/intel/kblrvp/smihandler.c b/src/mainboard/intel/kblrvp/smihandler.c index a12a460..bb09d78 100644 --- a/src/mainboard/intel/kblrvp/smihandler.c +++ b/src/mainboard/intel/kblrvp/smihandler.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <arch/acpi.h> #include <console/console.h> #include <cpu/x86/smm.h> #include <elog.h>
Hello Patrick Rudolph, Huang Jin, York Yang, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31715
to look at the new patch set (#2).
Change subject: src: Drop unused include <arch/acpi.h> ......................................................................
src: Drop unused include <arch/acpi.h>
Change-Id: I1f44ffeb54955ed660162a791c6281f292b1116a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/amd/pi/00630F01/model_15_init.c M src/cpu/amd/pi/00660F01/model_15_init.c M src/cpu/amd/pi/00730F01/model_16_init.c M src/cpu/intel/haswell/romstage.c M src/cpu/x86/mtrr/mtrr.c M src/mainboard/amd/bettong/mainboard.c M src/mainboard/amd/db-ft3b-lc/mainboard.c M src/mainboard/amd/gardenia/mainboard.c M src/mainboard/amd/lamar/mainboard.c M src/mainboard/amd/olivehillplus/mainboard.c M src/mainboard/amd/thatcher/romstage.c M src/mainboard/asrock/imb-a180/romstage.c M src/mainboard/asus/kcma-d8/romstage.c M src/mainboard/asus/kgpe-d16/romstage.c M src/mainboard/asus/p5gc-mx/romstage.c M src/mainboard/bap/ode_e21XX/mainboard.c M src/mainboard/getac/p470/mainboard.c M src/mainboard/getac/p470/romstage.c M src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c M src/mainboard/intel/bayleybay_fsp/mainboard.c M src/mainboard/intel/bayleybay_fsp/romstage.c M src/mainboard/intel/camelbackmountain_fsp/mainboard.c M src/mainboard/intel/dcp847ske/early_southbridge.c M src/mainboard/intel/emeraldlake2/romstage.c M src/mainboard/intel/kblrvp/smihandler.c M src/mainboard/kontron/ktqm77/mainboard.c M src/mainboard/kontron/ktqm77/romstage.c M src/mainboard/lenovo/t60/romstage.c M src/mainboard/lenovo/x1_carbon_gen1/romstage.c M src/mainboard/lenovo/x230/romstage.c M src/mainboard/lippert/frontrunner-af/mainboard.c M src/mainboard/lippert/toucan-af/mainboard.c M src/mainboard/pcengines/apu1/mainboard.c M src/mainboard/pcengines/apu2/mainboard.c M src/mainboard/roda/rk886ex/romstage.c M src/mainboard/samsung/lumpy/romstage.c M src/mainboard/samsung/stumpy/romstage.c M src/mainboard/siemens/mc_bdx1/mainboard.c M src/mainboard/siemens/mc_tcu3/mainboard.c M src/northbridge/intel/gm45/iommu.c M src/northbridge/intel/gm45/northbridge.c M src/northbridge/intel/i945/early_init.c M src/northbridge/intel/sandybridge/early_init.c M src/soc/amd/common/block/pi/heapmanager.c M src/soc/intel/baytrail/placeholders.c M src/soc/intel/braswell/placeholders.c M src/soc/intel/braswell/xhci.c M src/soc/intel/broadwell/cpu.c M src/soc/intel/denverton_ns/systemagent.c M src/soc/intel/fsp_broadwell_de/ramstage.c M src/southbridge/amd/agesa/hudson/early_setup.c M src/southbridge/amd/agesa/hudson/hudson.c M src/southbridge/amd/pi/hudson/early_setup.c 53 files changed, 3 insertions(+), 52 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/31715/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31715 )
Change subject: src: Drop unused include <arch/acpi.h> ......................................................................
Patch Set 2: Code-Review+1
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31715 )
Change subject: src: Drop unused include <arch/acpi.h> ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
https://review.coreboot.org/#/c/31715/2/src/mainboard/asus/kcma-d8/romstage.... File src/mainboard/asus/kcma-d8/romstage.c:
https://review.coreboot.org/#/c/31715/2/src/mainboard/asus/kcma-d8/romstage.... PS2, Line 23: #include <arch/acpi.h> Your commit message is about dropping and does not mention adding. Why do you need to add it anyway here? Because you dropped it in another file and it was included indirect? If this is the case, please make it clear it in the commit message.
https://review.coreboot.org/#/c/31715/2/src/mainboard/asus/kgpe-d16/romstage... File src/mainboard/asus/kgpe-d16/romstage.c:
https://review.coreboot.org/#/c/31715/2/src/mainboard/asus/kgpe-d16/romstage... PS2, Line 23: #include <arch/acpi.h> same
https://review.coreboot.org/#/c/31715/2/src/mainboard/getac/p470/mainboard.c File src/mainboard/getac/p470/mainboard.c:
https://review.coreboot.org/#/c/31715/2/src/mainboard/getac/p470/mainboard.c... PS2, Line 17: #include <arch/acpi.h> same
Hello Patrick Rudolph, Piotr Król, Paul Menzel, build bot (Jenkins), Werner Zeh, Alexander Couzens, Vanessa Eusebio, Huang Jin, York Yang, Philipp Deppenwiese, David Guckian, Michał Żygowski,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31715
to look at the new patch set (#4).
Change subject: src: Drop unused include <arch/acpi.h> ......................................................................
src: Drop unused include <arch/acpi.h>
Change-Id: I1f44ffeb54955ed660162a791c6281f292b1116a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/amd/pi/00630F01/model_15_init.c M src/cpu/amd/pi/00660F01/model_15_init.c M src/cpu/amd/pi/00730F01/model_16_init.c M src/cpu/intel/haswell/romstage.c M src/cpu/x86/mtrr/mtrr.c M src/mainboard/amd/bettong/mainboard.c M src/mainboard/amd/db-ft3b-lc/mainboard.c M src/mainboard/amd/gardenia/mainboard.c M src/mainboard/amd/lamar/mainboard.c M src/mainboard/amd/olivehillplus/mainboard.c M src/mainboard/amd/thatcher/romstage.c M src/mainboard/asrock/imb-a180/romstage.c M src/mainboard/asus/p5gc-mx/romstage.c M src/mainboard/bap/ode_e21XX/mainboard.c M src/mainboard/getac/p470/romstage.c M src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c M src/mainboard/intel/bayleybay_fsp/mainboard.c M src/mainboard/intel/bayleybay_fsp/romstage.c M src/mainboard/intel/camelbackmountain_fsp/mainboard.c M src/mainboard/intel/dcp847ske/early_southbridge.c M src/mainboard/intel/emeraldlake2/romstage.c M src/mainboard/intel/kblrvp/smihandler.c M src/mainboard/kontron/ktqm77/mainboard.c M src/mainboard/kontron/ktqm77/romstage.c M src/mainboard/lenovo/t60/romstage.c M src/mainboard/lenovo/x1_carbon_gen1/romstage.c M src/mainboard/lenovo/x230/romstage.c M src/mainboard/lippert/frontrunner-af/mainboard.c M src/mainboard/lippert/toucan-af/mainboard.c M src/mainboard/pcengines/apu1/mainboard.c M src/mainboard/pcengines/apu2/mainboard.c M src/mainboard/roda/rk886ex/romstage.c M src/mainboard/samsung/lumpy/romstage.c M src/mainboard/samsung/stumpy/romstage.c M src/mainboard/siemens/mc_bdx1/mainboard.c M src/mainboard/siemens/mc_tcu3/mainboard.c M src/northbridge/intel/gm45/iommu.c M src/northbridge/intel/gm45/northbridge.c M src/northbridge/intel/i945/early_init.c M src/northbridge/intel/sandybridge/early_init.c M src/soc/amd/common/block/pi/heapmanager.c M src/soc/intel/baytrail/placeholders.c M src/soc/intel/braswell/placeholders.c M src/soc/intel/braswell/xhci.c M src/soc/intel/broadwell/cpu.c M src/soc/intel/denverton_ns/systemagent.c M src/soc/intel/fsp_broadwell_de/ramstage.c M src/southbridge/amd/agesa/hudson/early_setup.c M src/southbridge/amd/agesa/hudson/hudson.c M src/southbridge/amd/pi/hudson/early_setup.c 50 files changed, 0 insertions(+), 52 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/31715/4
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31715 )
Change subject: src: Drop unused include <arch/acpi.h> ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31715 )
Change subject: src: Drop unused include <arch/acpi.h> ......................................................................
src: Drop unused include <arch/acpi.h>
Change-Id: I1f44ffeb54955ed660162a791c6281f292b1116a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/31715 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Werner Zeh werner.zeh@siemens.com --- M src/cpu/amd/pi/00630F01/model_15_init.c M src/cpu/amd/pi/00660F01/model_15_init.c M src/cpu/amd/pi/00730F01/model_16_init.c M src/cpu/intel/haswell/romstage.c M src/cpu/x86/mtrr/mtrr.c M src/mainboard/amd/bettong/mainboard.c M src/mainboard/amd/db-ft3b-lc/mainboard.c M src/mainboard/amd/gardenia/mainboard.c M src/mainboard/amd/lamar/mainboard.c M src/mainboard/amd/olivehillplus/mainboard.c M src/mainboard/amd/thatcher/romstage.c M src/mainboard/asrock/imb-a180/romstage.c M src/mainboard/asus/p5gc-mx/romstage.c M src/mainboard/bap/ode_e21XX/mainboard.c M src/mainboard/getac/p470/romstage.c M src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c M src/mainboard/intel/bayleybay_fsp/mainboard.c M src/mainboard/intel/bayleybay_fsp/romstage.c M src/mainboard/intel/camelbackmountain_fsp/mainboard.c M src/mainboard/intel/dcp847ske/early_southbridge.c M src/mainboard/intel/emeraldlake2/romstage.c M src/mainboard/intel/kblrvp/smihandler.c M src/mainboard/kontron/ktqm77/mainboard.c M src/mainboard/kontron/ktqm77/romstage.c M src/mainboard/lenovo/t60/romstage.c M src/mainboard/lenovo/x1_carbon_gen1/romstage.c M src/mainboard/lenovo/x230/romstage.c M src/mainboard/lippert/frontrunner-af/mainboard.c M src/mainboard/lippert/toucan-af/mainboard.c M src/mainboard/pcengines/apu1/mainboard.c M src/mainboard/pcengines/apu2/mainboard.c M src/mainboard/roda/rk886ex/romstage.c M src/mainboard/samsung/lumpy/romstage.c M src/mainboard/samsung/stumpy/romstage.c M src/mainboard/siemens/mc_bdx1/mainboard.c M src/mainboard/siemens/mc_tcu3/mainboard.c M src/northbridge/intel/gm45/iommu.c M src/northbridge/intel/gm45/northbridge.c M src/northbridge/intel/i945/early_init.c M src/northbridge/intel/sandybridge/early_init.c M src/soc/amd/common/block/pi/heapmanager.c M src/soc/intel/baytrail/placeholders.c M src/soc/intel/braswell/placeholders.c M src/soc/intel/braswell/xhci.c M src/soc/intel/broadwell/cpu.c M src/soc/intel/denverton_ns/systemagent.c M src/soc/intel/fsp_broadwell_de/ramstage.c M src/southbridge/amd/agesa/hudson/early_setup.c M src/southbridge/amd/agesa/hudson/hudson.c M src/southbridge/amd/pi/hudson/early_setup.c 50 files changed, 0 insertions(+), 52 deletions(-)
Approvals: build bot (Jenkins): Verified Werner Zeh: Looks good to me, approved
diff --git a/src/cpu/amd/pi/00630F01/model_15_init.c b/src/cpu/amd/pi/00630F01/model_15_init.c index d364513..5455b0c 100644 --- a/src/cpu/amd/pi/00630F01/model_15_init.c +++ b/src/cpu/amd/pi/00630F01/model_15_init.c @@ -26,7 +26,6 @@ #include <cpu/x86/lapic.h> #include <cpu/cpu.h> #include <cpu/x86/cache.h> -#include <arch/acpi.h>
static void model_15_init(struct device *dev) { diff --git a/src/cpu/amd/pi/00660F01/model_15_init.c b/src/cpu/amd/pi/00660F01/model_15_init.c index 818cfa4..d156525 100644 --- a/src/cpu/amd/pi/00660F01/model_15_init.c +++ b/src/cpu/amd/pi/00660F01/model_15_init.c @@ -25,7 +25,6 @@ #include <cpu/x86/lapic.h> #include <cpu/cpu.h> #include <cpu/x86/cache.h> -#include <arch/acpi.h>
#include <amdlib.h> #include <PspBaseLib.h> diff --git a/src/cpu/amd/pi/00730F01/model_16_init.c b/src/cpu/amd/pi/00730F01/model_16_init.c index 9be6e2a..7ae89b4 100644 --- a/src/cpu/amd/pi/00730F01/model_16_init.c +++ b/src/cpu/amd/pi/00730F01/model_16_init.c @@ -25,7 +25,6 @@ #include <cpu/x86/lapic.h> #include <cpu/cpu.h> #include <cpu/x86/cache.h> -#include <arch/acpi.h>
static void model_16_init(struct device *dev) { diff --git a/src/cpu/intel/haswell/romstage.c b/src/cpu/intel/haswell/romstage.c index e2dd0fa..d5028c2 100644 --- a/src/cpu/intel/haswell/romstage.c +++ b/src/cpu/intel/haswell/romstage.c @@ -24,7 +24,6 @@ #include <halt.h> #include <lib.h> #include <timestamp.h> -#include <arch/acpi.h> #include <device/pci_def.h> #include <cpu/x86/lapic.h> #include <cbmem.h> diff --git a/src/cpu/x86/mtrr/mtrr.c b/src/cpu/x86/mtrr/mtrr.c index 249d631..b45d17f 100644 --- a/src/cpu/x86/mtrr/mtrr.c +++ b/src/cpu/x86/mtrr/mtrr.c @@ -33,7 +33,6 @@ #include <cpu/x86/mtrr.h> #include <cpu/x86/cache.h> #include <cpu/x86/lapic.h> -#include <arch/acpi.h> #include <memrange.h> #include <cpu/amd/mtrr.h> #include <assert.h> diff --git a/src/mainboard/amd/bettong/mainboard.c b/src/mainboard/amd/bettong/mainboard.c index 16fc47e..80b888e 100644 --- a/src/mainboard/amd/bettong/mainboard.c +++ b/src/mainboard/amd/bettong/mainboard.c @@ -15,7 +15,6 @@
#include <console/console.h> #include <device/device.h> -#include <arch/acpi.h> #include <agesawrapper.h> #include <southbridge/amd/common/amd_pci_util.h>
diff --git a/src/mainboard/amd/db-ft3b-lc/mainboard.c b/src/mainboard/amd/db-ft3b-lc/mainboard.c index d5ae995..6ea80ed 100644 --- a/src/mainboard/amd/db-ft3b-lc/mainboard.c +++ b/src/mainboard/amd/db-ft3b-lc/mainboard.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <arch/acpi.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/mainboard/amd/gardenia/mainboard.c b/src/mainboard/amd/gardenia/mainboard.c index 86dfed4..b3f2285 100644 --- a/src/mainboard/amd/gardenia/mainboard.c +++ b/src/mainboard/amd/gardenia/mainboard.c @@ -15,7 +15,6 @@
#include <console/console.h> #include <device/device.h> -#include <arch/acpi.h> #include <amdblocks/agesawrapper.h> #include <amdblocks/amd_pci_util.h> #include <soc/southbridge.h> diff --git a/src/mainboard/amd/lamar/mainboard.c b/src/mainboard/amd/lamar/mainboard.c index 08d21c8..3d33850 100644 --- a/src/mainboard/amd/lamar/mainboard.c +++ b/src/mainboard/amd/lamar/mainboard.c @@ -17,7 +17,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_def.h> -#include <arch/acpi.h> #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <northbridge/amd/pi/00630F01/pci_devs.h> diff --git a/src/mainboard/amd/olivehillplus/mainboard.c b/src/mainboard/amd/olivehillplus/mainboard.c index 45841f9..00ac1a4 100644 --- a/src/mainboard/amd/olivehillplus/mainboard.c +++ b/src/mainboard/amd/olivehillplus/mainboard.c @@ -17,7 +17,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_def.h> -#include <arch/acpi.h> #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h>
diff --git a/src/mainboard/amd/thatcher/romstage.c b/src/mainboard/amd/thatcher/romstage.c index ed22ed1..54ced88 100644 --- a/src/mainboard/amd/thatcher/romstage.c +++ b/src/mainboard/amd/thatcher/romstage.c @@ -16,7 +16,6 @@ #include <stdint.h> #include <string.h> #include <device/pci_def.h> -#include <arch/acpi.h> #include <arch/io.h> #include <device/pci_ops.h> #include <commonlib/loglevel.h> diff --git a/src/mainboard/asrock/imb-a180/romstage.c b/src/mainboard/asrock/imb-a180/romstage.c index 83fc9a0..c100a61 100644 --- a/src/mainboard/asrock/imb-a180/romstage.c +++ b/src/mainboard/asrock/imb-a180/romstage.c @@ -16,7 +16,6 @@ #include <stdint.h> #include <string.h> #include <device/pci_def.h> -#include <arch/acpi.h> #include <arch/io.h> #include <device/pci_ops.h> #include <commonlib/loglevel.h> diff --git a/src/mainboard/asus/p5gc-mx/romstage.c b/src/mainboard/asus/p5gc-mx/romstage.c index 2f45113..26898cc 100644 --- a/src/mainboard/asus/p5gc-mx/romstage.c +++ b/src/mainboard/asus/p5gc-mx/romstage.c @@ -24,7 +24,6 @@ #include <device/pci_ops.h> #include <device/pci_def.h> #include <cpu/x86/lapic.h> -#include <arch/acpi.h> #include <superio/winbond/common/winbond.h> #include <superio/winbond/w83627dhg/w83627dhg.h> #include <console/console.h> diff --git a/src/mainboard/bap/ode_e21XX/mainboard.c b/src/mainboard/bap/ode_e21XX/mainboard.c index 45841f9..00ac1a4 100644 --- a/src/mainboard/bap/ode_e21XX/mainboard.c +++ b/src/mainboard/bap/ode_e21XX/mainboard.c @@ -17,7 +17,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_def.h> -#include <arch/acpi.h> #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h>
diff --git a/src/mainboard/getac/p470/romstage.c b/src/mainboard/getac/p470/romstage.c index 2f90572..b7b5efe 100644 --- a/src/mainboard/getac/p470/romstage.c +++ b/src/mainboard/getac/p470/romstage.c @@ -21,7 +21,6 @@ #include <device/pci_ops.h> #include <device/pci_def.h> #include <cpu/x86/lapic.h> -#include <arch/acpi.h> #include <pc80/mc146818rtc.h> #include <console/console.h> #include <cpu/x86/bist.h> diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c b/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c index 4f445ab..b3ee2a8 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c @@ -21,7 +21,6 @@ #include <device/pci_ops.h> #include <device/pci_def.h> #include <cpu/x86/lapic.h> -#include <arch/acpi.h> #include <superio/ite/it8718f/it8718f.h> #include <superio/ite/common/ite.h> #include <console/console.h> diff --git a/src/mainboard/intel/bayleybay_fsp/mainboard.c b/src/mainboard/intel/bayleybay_fsp/mainboard.c index 00f5f5d..9424855 100644 --- a/src/mainboard/intel/bayleybay_fsp/mainboard.c +++ b/src/mainboard/intel/bayleybay_fsp/mainboard.c @@ -22,7 +22,6 @@ #if IS_ENABLED(CONFIG_VGA_ROM_RUN) #include <x86emu/x86emu.h> #endif -#include <arch/acpi.h> #include <arch/interrupt.h> #include <boot/coreboot_tables.h>
diff --git a/src/mainboard/intel/bayleybay_fsp/romstage.c b/src/mainboard/intel/bayleybay_fsp/romstage.c index e3deddd..7c906ce 100644 --- a/src/mainboard/intel/bayleybay_fsp/romstage.c +++ b/src/mainboard/intel/bayleybay_fsp/romstage.c @@ -24,7 +24,6 @@ #include <soc/lpc.h> #include <soc/pci_devs.h> #include <soc/romstage.h> -#include <soc/acpi.h> #include <soc/baytrail.h> #include <drivers/intel/fsp1_0/fsp_util.h>
diff --git a/src/mainboard/intel/camelbackmountain_fsp/mainboard.c b/src/mainboard/intel/camelbackmountain_fsp/mainboard.c index e73da8d..946a453 100644 --- a/src/mainboard/intel/camelbackmountain_fsp/mainboard.c +++ b/src/mainboard/intel/camelbackmountain_fsp/mainboard.c @@ -22,7 +22,6 @@ #if IS_ENABLED(CONFIG_VGA_ROM_RUN) #include <x86emu/x86emu.h> #endif -#include <arch/acpi.h> #include <arch/interrupt.h> #include <boot/coreboot_tables.h>
diff --git a/src/mainboard/intel/dcp847ske/early_southbridge.c b/src/mainboard/intel/dcp847ske/early_southbridge.c index 233800a..1a46f8b 100644 --- a/src/mainboard/intel/dcp847ske/early_southbridge.c +++ b/src/mainboard/intel/dcp847ske/early_southbridge.c @@ -21,7 +21,6 @@ #include <arch/io.h> #include <device/pci_ops.h> #include <device/pci_def.h> -#include <arch/acpi.h> #include <console/console.h> #include <northbridge/intel/sandybridge/raminit_native.h>
diff --git a/src/mainboard/intel/emeraldlake2/romstage.c b/src/mainboard/intel/emeraldlake2/romstage.c index 4074a30..d5ba961 100644 --- a/src/mainboard/intel/emeraldlake2/romstage.c +++ b/src/mainboard/intel/emeraldlake2/romstage.c @@ -21,7 +21,6 @@ #include <device/pci_ops.h> #include <device/pci_def.h> #include <cpu/x86/lapic.h> -#include <arch/acpi.h> #include <superio/smsc/sio1007/chip.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit.h> diff --git a/src/mainboard/intel/kblrvp/smihandler.c b/src/mainboard/intel/kblrvp/smihandler.c index a12a460..bb09d78 100644 --- a/src/mainboard/intel/kblrvp/smihandler.c +++ b/src/mainboard/intel/kblrvp/smihandler.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <arch/acpi.h> #include <console/console.h> #include <cpu/x86/smm.h> #include <elog.h> diff --git a/src/mainboard/kontron/ktqm77/mainboard.c b/src/mainboard/kontron/ktqm77/mainboard.c index 4a5ad93..c2a8721 100644 --- a/src/mainboard/kontron/ktqm77/mainboard.c +++ b/src/mainboard/kontron/ktqm77/mainboard.c @@ -25,7 +25,6 @@ #include <x86emu/x86emu.h> #endif #include <pc80/mc146818rtc.h> -#include <arch/acpi.h> #include <arch/interrupt.h> #include <boot/coreboot_tables.h> #include <southbridge/intel/bd82x6x/pch.h> diff --git a/src/mainboard/kontron/ktqm77/romstage.c b/src/mainboard/kontron/ktqm77/romstage.c index 30800e8..8c53420 100644 --- a/src/mainboard/kontron/ktqm77/romstage.c +++ b/src/mainboard/kontron/ktqm77/romstage.c @@ -16,7 +16,6 @@
#include <stdint.h> #include <string.h> -#include <arch/acpi.h> #include <device/pnp_ops.h> #include <device/pci_ops.h> #include <cpu/x86/lapic.h> diff --git a/src/mainboard/lenovo/t60/romstage.c b/src/mainboard/lenovo/t60/romstage.c index daf4179..efb03b1 100644 --- a/src/mainboard/lenovo/t60/romstage.c +++ b/src/mainboard/lenovo/t60/romstage.c @@ -25,7 +25,6 @@ #include <device/pci_def.h> #include <device/pnp_def.h> #include <cpu/x86/lapic.h> -#include <arch/acpi.h> #include <console/console.h> #include <cpu/x86/bist.h> #include <cpu/intel/romstage.h> diff --git a/src/mainboard/lenovo/x1_carbon_gen1/romstage.c b/src/mainboard/lenovo/x1_carbon_gen1/romstage.c index 13d9a19..e3d2000 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/romstage.c +++ b/src/mainboard/lenovo/x1_carbon_gen1/romstage.c @@ -23,7 +23,6 @@ #include <device/pci_ops.h> #include <device/pci_def.h> #include <cpu/x86/lapic.h> -#include <arch/acpi.h> #include <console/console.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit_native.h> diff --git a/src/mainboard/lenovo/x230/romstage.c b/src/mainboard/lenovo/x230/romstage.c index b88d8f5..b85e720 100644 --- a/src/mainboard/lenovo/x230/romstage.c +++ b/src/mainboard/lenovo/x230/romstage.c @@ -22,7 +22,6 @@ #include <device/pci_ops.h> #include <device/pci_def.h> #include <cpu/x86/lapic.h> -#include <arch/acpi.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit_native.h> #include <southbridge/intel/bd82x6x/pch.h> diff --git a/src/mainboard/lippert/frontrunner-af/mainboard.c b/src/mainboard/lippert/frontrunner-af/mainboard.c index 8d4aff0..6530276 100644 --- a/src/mainboard/lippert/frontrunner-af/mainboard.c +++ b/src/mainboard/lippert/frontrunner-af/mainboard.c @@ -22,7 +22,6 @@ #include <device/pci_ops.h> #include <device/pci_def.h> #include <southbridge/amd/sb800/sb800.h> -#include <arch/acpi.h> #include <southbridge/amd/cimx/sb800/SBPLATFORM.h> #include <vendorcode/amd/cimx/sb800/OEM.h> /* SMBUS0_BASE_ADDRESS */ #include <southbridge/amd/cimx/sb800/gpio_oem.h> diff --git a/src/mainboard/lippert/toucan-af/mainboard.c b/src/mainboard/lippert/toucan-af/mainboard.c index 135b0a3..b7126ea 100644 --- a/src/mainboard/lippert/toucan-af/mainboard.c +++ b/src/mainboard/lippert/toucan-af/mainboard.c @@ -21,7 +21,6 @@ #include <device/pci_ops.h> #include <device/pci_def.h> #include <southbridge/amd/sb800/sb800.h> -#include <arch/acpi.h> #include <southbridge/amd/cimx/sb800/SBPLATFORM.h> #include <vendorcode/amd/cimx/sb800/OEM.h> /* SMBUS0_BASE_ADDRESS */ #include <southbridge/amd/cimx/sb800/gpio_oem.h> diff --git a/src/mainboard/pcengines/apu1/mainboard.c b/src/mainboard/pcengines/apu1/mainboard.c index ac95894..10460bd 100644 --- a/src/mainboard/pcengines/apu1/mainboard.c +++ b/src/mainboard/pcengines/apu1/mainboard.c @@ -22,7 +22,6 @@ #include <device/pci_def.h> #include <southbridge/amd/common/amd_pci_util.h> #include <southbridge/amd/cimx/cimx_util.h> -#include <arch/acpi.h> #include <smbios.h> #include <string.h> #include <southbridge/amd/cimx/sb800/SBPLATFORM.h> diff --git a/src/mainboard/pcengines/apu2/mainboard.c b/src/mainboard/pcengines/apu2/mainboard.c index baad54c..16bbf8a 100644 --- a/src/mainboard/pcengines/apu2/mainboard.c +++ b/src/mainboard/pcengines/apu2/mainboard.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/acpi.h> #include <device/mmio.h> #include <device/pci_ops.h> #include <console/console.h> diff --git a/src/mainboard/roda/rk886ex/romstage.c b/src/mainboard/roda/rk886ex/romstage.c index b36d78b..fbda731 100644 --- a/src/mainboard/roda/rk886ex/romstage.c +++ b/src/mainboard/roda/rk886ex/romstage.c @@ -23,7 +23,6 @@ #include <device/pci_ops.h> #include <device/pci_def.h> #include <cpu/x86/lapic.h> -#include <arch/acpi.h> #include <pc80/mc146818rtc.h> #include <console/console.h> #include <cpu/x86/bist.h> diff --git a/src/mainboard/samsung/lumpy/romstage.c b/src/mainboard/samsung/lumpy/romstage.c index 244ce7c..d39d59c 100644 --- a/src/mainboard/samsung/lumpy/romstage.c +++ b/src/mainboard/samsung/lumpy/romstage.c @@ -22,7 +22,6 @@ #include <device/pci_def.h> #include <cpu/x86/lapic.h> #include <cbfs.h> -#include <arch/acpi.h> #include <console/console.h> #include <bootmode.h> #include <northbridge/intel/sandybridge/sandybridge.h> diff --git a/src/mainboard/samsung/stumpy/romstage.c b/src/mainboard/samsung/stumpy/romstage.c index c45ca7e..1c4e3d8 100644 --- a/src/mainboard/samsung/stumpy/romstage.c +++ b/src/mainboard/samsung/stumpy/romstage.c @@ -21,7 +21,6 @@ #include <device/pci_def.h> #include <cpu/x86/lapic.h> #include <pc80/mc146818rtc.h> -#include <arch/acpi.h> #include <console/console.h> #include <bootmode.h> #include <superio/ite/common/ite.h> diff --git a/src/mainboard/siemens/mc_bdx1/mainboard.c b/src/mainboard/siemens/mc_bdx1/mainboard.c index fb4d1e3..1f87378 100644 --- a/src/mainboard/siemens/mc_bdx1/mainboard.c +++ b/src/mainboard/siemens/mc_bdx1/mainboard.c @@ -26,7 +26,6 @@ #if IS_ENABLED(CONFIG_VGA_ROM_RUN) #include <x86emu/x86emu.h> #endif -#include <arch/acpi.h> #include <device/mmio.h> #include <arch/interrupt.h> #include <boot/coreboot_tables.h> diff --git a/src/mainboard/siemens/mc_tcu3/mainboard.c b/src/mainboard/siemens/mc_tcu3/mainboard.c index 469d221..ecc2b27 100644 --- a/src/mainboard/siemens/mc_tcu3/mainboard.c +++ b/src/mainboard/siemens/mc_tcu3/mainboard.c @@ -22,7 +22,6 @@ #if IS_ENABLED(CONFIG_VGA_ROM_RUN) #include <x86emu/x86emu.h> #endif -#include <arch/acpi.h> #include <arch/interrupt.h> #include <boot/coreboot_tables.h> #include <hwilib.h> diff --git a/src/northbridge/intel/gm45/iommu.c b/src/northbridge/intel/gm45/iommu.c index 93e6316..b6e38e7 100644 --- a/src/northbridge/intel/gm45/iommu.c +++ b/src/northbridge/intel/gm45/iommu.c @@ -19,7 +19,6 @@
#include <device/pci_ops.h> #include <device/pci_def.h> -#include <arch/acpi.h>
#include "gm45.h"
diff --git a/src/northbridge/intel/gm45/northbridge.c b/src/northbridge/intel/gm45/northbridge.c index eda5e92..40e4f61 100644 --- a/src/northbridge/intel/gm45/northbridge.c +++ b/src/northbridge/intel/gm45/northbridge.c @@ -27,7 +27,6 @@ #include <cpu/intel/smm/gen1/smi.h> #include "chip.h" #include "gm45.h" -#include "arch/acpi.h"
/* Reserve segments A and B: * diff --git a/src/northbridge/intel/i945/early_init.c b/src/northbridge/intel/i945/early_init.c index d9d88bb..1913b52 100644 --- a/src/northbridge/intel/i945/early_init.c +++ b/src/northbridge/intel/i945/early_init.c @@ -16,7 +16,6 @@ #include <stdint.h> #include <stdlib.h> #include <console/console.h> -#include <arch/acpi.h> #include <arch/io.h> #include <device/pci_ops.h> #include <device/pci_def.h> diff --git a/src/northbridge/intel/sandybridge/early_init.c b/src/northbridge/intel/sandybridge/early_init.c index 01787f1..44eebf3 100644 --- a/src/northbridge/intel/sandybridge/early_init.c +++ b/src/northbridge/intel/sandybridge/early_init.c @@ -19,7 +19,6 @@ #include <console/console.h> #include <arch/io.h> #include <device/pci_ops.h> -#include <arch/acpi.h> #include <device/pci_def.h> #include <elog.h> #include <pc80/mc146818rtc.h> diff --git a/src/soc/amd/common/block/pi/heapmanager.c b/src/soc/amd/common/block/pi/heapmanager.c index 683a572..3b383ac 100644 --- a/src/soc/amd/common/block/pi/heapmanager.c +++ b/src/soc/amd/common/block/pi/heapmanager.c @@ -13,7 +13,6 @@
#include <amdblocks/agesawrapper.h> -#include <arch/acpi.h> #include <amdblocks/BiosCallOuts.h> #include <cbmem.h> #include <string.h> diff --git a/src/soc/intel/baytrail/placeholders.c b/src/soc/intel/baytrail/placeholders.c index b476409..e7b2098 100644 --- a/src/soc/intel/baytrail/placeholders.c +++ b/src/soc/intel/baytrail/placeholders.c @@ -12,7 +12,6 @@ * GNU General Public License for more details. */
-#include <arch/acpi.h> #include <device/pci_rom.h> #include <soc/acpi.h>
diff --git a/src/soc/intel/braswell/placeholders.c b/src/soc/intel/braswell/placeholders.c index 7e633d9..503c431 100644 --- a/src/soc/intel/braswell/placeholders.c +++ b/src/soc/intel/braswell/placeholders.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/acpi.h> #include <device/pci_rom.h> #include <soc/acpi.h>
diff --git a/src/soc/intel/braswell/xhci.c b/src/soc/intel/braswell/xhci.c index 49b6c4b..6c90482 100644 --- a/src/soc/intel/braswell/xhci.c +++ b/src/soc/intel/braswell/xhci.c @@ -15,7 +15,6 @@ * */
-#include <arch/acpi.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/soc/intel/broadwell/cpu.c b/src/soc/intel/broadwell/cpu.c index 10ae489..d274be8 100644 --- a/src/soc/intel/broadwell/cpu.c +++ b/src/soc/intel/broadwell/cpu.c @@ -18,7 +18,6 @@ #include <device/device.h> #include <device/pci.h> #include <string.h> -#include <arch/acpi.h> #include <arch/cpu.h> #include <cpu/cpu.h> #include <cpu/x86/mtrr.h> diff --git a/src/soc/intel/denverton_ns/systemagent.c b/src/soc/intel/denverton_ns/systemagent.c index 22eae36..dbcc51a 100644 --- a/src/soc/intel/denverton_ns/systemagent.c +++ b/src/soc/intel/denverton_ns/systemagent.c @@ -16,7 +16,6 @@ */
#include <console/console.h> -#include <arch/acpi.h> #include <device/mmio.h> #include <device/pci_ops.h> #include <stdint.h> diff --git a/src/soc/intel/fsp_broadwell_de/ramstage.c b/src/soc/intel/fsp_broadwell_de/ramstage.c index 492378e..a64e337 100644 --- a/src/soc/intel/fsp_broadwell_de/ramstage.c +++ b/src/soc/intel/fsp_broadwell_de/ramstage.c @@ -16,7 +16,6 @@
#include <stdlib.h> #include <arch/cpu.h> -#include <arch/acpi.h> #include <console/console.h> #include <cpu/intel/microcode.h> #include <cpu/x86/cr.h> diff --git a/src/southbridge/amd/agesa/hudson/early_setup.c b/src/southbridge/amd/agesa/hudson/early_setup.c index 6229315..f71f453 100644 --- a/src/southbridge/amd/agesa/hudson/early_setup.c +++ b/src/southbridge/amd/agesa/hudson/early_setup.c @@ -19,7 +19,6 @@ #include <stdint.h> #include <arch/io.h> #include <device/pci_ops.h> -#include <arch/acpi.h> #include <console/console.h> #include <reset.h> #include "hudson.h" diff --git a/src/southbridge/amd/agesa/hudson/hudson.c b/src/southbridge/amd/agesa/hudson/hudson.c index 6de016a..8ae685e 100644 --- a/src/southbridge/amd/agesa/hudson/hudson.c +++ b/src/southbridge/amd/agesa/hudson/hudson.c @@ -14,10 +14,7 @@ */
#include <console/console.h> - #include <device/mmio.h> -#include <arch/acpi.h> - #include <device/device.h> #include <device/pci.h> #include <device/pci_def.h> diff --git a/src/southbridge/amd/pi/hudson/early_setup.c b/src/southbridge/amd/pi/hudson/early_setup.c index 1e9f189..25be669 100644 --- a/src/southbridge/amd/pi/hudson/early_setup.c +++ b/src/southbridge/amd/pi/hudson/early_setup.c @@ -21,7 +21,6 @@ #include <arch/io.h> #include <device/mmio.h> #include <device/pci_ops.h> -#include <arch/acpi.h> #include <console/console.h> #include <reset.h> #include "hudson.h"
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Werner Zeh (Code Review)