Aaron Durbin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38611 )
Change subject: soc/amd/stoneyridge: use SMBus speed in compliation unit ......................................................................
soc/amd/stoneyridge: use SMBus speed in compliation unit
The fixed bus speed of 400 kHz doesn't need to reside in a header file. Just move the assumption into the code itself.
Change-Id: I426fe078909a9b725c1747380d69af31292b6d1e Signed-off-by: Aaron Durbin adurbin@chromium.org --- M src/soc/amd/stoneyridge/include/soc/smbus.h M src/soc/amd/stoneyridge/southbridge.c 2 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/38611/1
diff --git a/src/soc/amd/stoneyridge/include/soc/smbus.h b/src/soc/amd/stoneyridge/include/soc/smbus.h index 391084d..4638fcd 100644 --- a/src/soc/amd/stoneyridge/include/soc/smbus.h +++ b/src/soc/amd/stoneyridge/include/soc/smbus.h @@ -19,8 +19,6 @@ #include <stdint.h> #include <soc/iomap.h>
-#define SMB_SPEED_400KHZ (66000000 / (400000 * 4)) - /* * Between 1-10 seconds, We should never timeout normally * Longer than this is just painful when a timeout condition occurs. diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c index 1b2afec..b0aaf24 100644 --- a/src/soc/amd/stoneyridge/southbridge.c +++ b/src/soc/amd/stoneyridge/southbridge.c @@ -378,8 +378,11 @@
static void fch_smbus_init(void) { + /* 400 kHz smbus speed. */ + const uint8_t smbus_speed = (66000000 / (400000 * 4)); + pm_write8(SMB_ASF_IO_BASE, SMB_BASE_ADDR >> 8); - smbus_write8(SMBTIMING, SMB_SPEED_400KHZ); + smbus_write8(SMBTIMING, smbus_speed); /* Clear all SMBUS status bits */ smbus_write8(SMBHSTSTAT, SMBHST_STAT_CLEAR); smbus_write8(SMBSLVSTAT, SMBSLV_STAT_CLEAR);
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38611 )
Change subject: soc/amd/stoneyridge: use SMBus speed in compliation unit ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38611/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38611/1//COMMIT_MSG@7 PS1, Line 7: compliation compilation
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38611 )
Change subject: soc/amd/stoneyridge: use SMBus speed in compliation unit ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38611/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38611/1//COMMIT_MSG@7 PS1, Line 7: compliation
compilation
Done
Aaron Durbin has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/38611 )
Change subject: soc/amd/stoneyridge: use SMBus speed in compilation unit ......................................................................
soc/amd/stoneyridge: use SMBus speed in compilation unit
The fixed bus speed of 400 kHz doesn't need to reside in a header file. Just move the assumption into the code itself.
Change-Id: I426fe078909a9b725c1747380d69af31292b6d1e Signed-off-by: Aaron Durbin adurbin@chromium.org --- M src/soc/amd/stoneyridge/include/soc/smbus.h M src/soc/amd/stoneyridge/southbridge.c 2 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/38611/2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38611 )
Change subject: soc/amd/stoneyridge: use SMBus speed in compilation unit ......................................................................
Patch Set 2: Code-Review+1
Until things clear about what is maintained by vendor and what is not, I am downgrading my +2 to +1 here.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38611 )
Change subject: soc/amd/stoneyridge: use SMBus speed in compilation unit ......................................................................
Patch Set 3:
This series should fix up and align things between stoney and picasso.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38611 )
Change subject: soc/amd/stoneyridge: use SMBus speed in compilation unit ......................................................................
Patch Set 3: Code-Review+2
Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38611 )
Change subject: soc/amd/stoneyridge: use SMBus speed in compilation unit ......................................................................
soc/amd/stoneyridge: use SMBus speed in compilation unit
The fixed bus speed of 400 kHz doesn't need to reside in a header file. Just move the assumption into the code itself.
Change-Id: I426fe078909a9b725c1747380d69af31292b6d1e Signed-off-by: Aaron Durbin adurbin@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/38611 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/stoneyridge/include/soc/smbus.h M src/soc/amd/stoneyridge/southbridge.c 2 files changed, 4 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/soc/amd/stoneyridge/include/soc/smbus.h b/src/soc/amd/stoneyridge/include/soc/smbus.h index 391084d..4638fcd 100644 --- a/src/soc/amd/stoneyridge/include/soc/smbus.h +++ b/src/soc/amd/stoneyridge/include/soc/smbus.h @@ -19,8 +19,6 @@ #include <stdint.h> #include <soc/iomap.h>
-#define SMB_SPEED_400KHZ (66000000 / (400000 * 4)) - /* * Between 1-10 seconds, We should never timeout normally * Longer than this is just painful when a timeout condition occurs. diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c index 1b2afec..b0aaf24 100644 --- a/src/soc/amd/stoneyridge/southbridge.c +++ b/src/soc/amd/stoneyridge/southbridge.c @@ -378,8 +378,11 @@
static void fch_smbus_init(void) { + /* 400 kHz smbus speed. */ + const uint8_t smbus_speed = (66000000 / (400000 * 4)); + pm_write8(SMB_ASF_IO_BASE, SMB_BASE_ADDR >> 8); - smbus_write8(SMBTIMING, SMB_SPEED_400KHZ); + smbus_write8(SMBTIMING, smbus_speed); /* Clear all SMBUS status bits */ smbus_write8(SMBHSTSTAT, SMBHST_STAT_CLEAR); smbus_write8(SMBSLVSTAT, SMBSLV_STAT_CLEAR);
-
Aaron Durbin (Code Review) -
Angel Pons (Code Review)
-
HAOUAS Elyes (Code Review)
-
Kyösti Mälkki (Code Review)