Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32618
Change subject: Kconfig: Enable coreboot lite firmware flow ......................................................................
Kconfig: Enable coreboot lite firmware flow
This patch enables coreboot flow to skip ramstage as individual stage to load payload. Instead it is expected to load payload from postcar stage.
Change-Id: I839f2d34a93b69ca6bf3de6594e2ad9f66ee7135 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/Kconfig 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/32618/1
diff --git a/src/Kconfig b/src/Kconfig index b4898bd..4642b85 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -1198,3 +1198,11 @@
config CBFS_SIZE default ROM_SIZE + +config COREBOOT_LITE + bool "Enable Coreboot Lite flow (remove ramstage)" + default n + help + If this option is enabled, coreboot flow will skip ramstage + loading and execute ramstage to load payload. + Instead it is expected to load payload from postcar stage itself.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32618
to look at the new patch set (#2).
Change subject: Kconfig: Enable coreboot lite firmware flow ......................................................................
Kconfig: Enable coreboot lite firmware flow
This patch enables coreboot flow to skip ramstage as individual stage to load payload. Instead it is expected to load payload from postcar stage.
Change-Id: I839f2d34a93b69ca6bf3de6594e2ad9f66ee7135 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/Kconfig 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/32618/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32618
to look at the new patch set (#3).
Change subject: Kconfig: Enable coreboot lite firmware flow ......................................................................
Kconfig: Enable coreboot lite firmware flow
This patch enables coreboot flow to skip ramstage as individual stage to load payload. Instead it is expected to load payload from postcar stage.
Change-Id: I839f2d34a93b69ca6bf3de6594e2ad9f66ee7135 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/Kconfig 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/32618/3
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32618 )
Change subject: Kconfig: Enable coreboot lite firmware flow ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/32618/3/src/Kconfig File src/Kconfig:
https://review.coreboot.org/#/c/32618/3/src/Kconfig@280 PS3, Line 280: config COREBOOT_LITE Should that be the marketing name?
Maybe just use COREBOOT_WO_RAMSTAGE?
https://review.coreboot.org/#/c/32618/3/src/Kconfig@285 PS3, Line 285: execute execution?
https://review.coreboot.org/#/c/32618/3/src/Kconfig@286 PS3, Line 286: Instead it is expected to load payload from postcar stage itself. Please add a blank line above.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32618 )
Change subject: Kconfig: Enable coreboot lite firmware flow ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/32618/3/src/Kconfig File src/Kconfig:
https://review.coreboot.org/#/c/32618/3/src/Kconfig@280 PS3, Line 280: config COREBOOT_LITE
Should that be the marketing name? […]
I think CONFIG_NO_RAMSTAGE or CONFIG_SKIP_RAMSTAGE would be the most reasonable names for this.
https://review.coreboot.org/#/c/32618/3/src/Kconfig@281 PS3, Line 281: bool "Enable coreboot lite flow (remove ramstage)" Does this need a depends on ARCH_X86 (at least for now)?
https://review.coreboot.org/#/c/32618/3/src/Kconfig@283 PS3, Line 283: help This should have a lot more explanation what this choice entails (e.g. no PCI enumeration or whatever), or refer to a Documentation/ file with more details.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32618 )
Change subject: Kconfig: Enable coreboot lite firmware flow ......................................................................
Patch Set 3:
(6 comments)
https://review.coreboot.org/#/c/32618/3/src/Kconfig File src/Kconfig:
https://review.coreboot.org/#/c/32618/3/src/Kconfig@280 PS3, Line 280: config COREBOOT_LITE
I think CONFIG_NO_RAMSTAGE or CONFIG_SKIP_RAMSTAGE would be the most reasonable names for this.
i like SKIP_RAMSTAGE name. thanks
https://review.coreboot.org/#/c/32618/3/src/Kconfig@280 PS3, Line 280: config COREBOOT_LITE
Should that be the marketing name? […]
Done
https://review.coreboot.org/#/c/32618/3/src/Kconfig@281 PS3, Line 281: bool "Enable coreboot lite flow (remove ramstage)"
Does this need a depends on ARCH_X86 (at least for now)?
totally agree
https://review.coreboot.org/#/c/32618/3/src/Kconfig@283 PS3, Line 283: help
This should have a lot more explanation what this choice entails (e.g. […]
i can add design document later and provide link here.
for now i have added few more details as you have mentioned
https://review.coreboot.org/#/c/32618/3/src/Kconfig@285 PS3, Line 285: execute
execution?
Done
https://review.coreboot.org/#/c/32618/3/src/Kconfig@286 PS3, Line 286: Instead it is expected to load payload from postcar stage itself.
Please add a blank line above.
Done
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32618 )
Change subject: Kconfig: Create SKIP_RAMSTAGE kconfig ......................................................................
Patch Set 4: Code-Review-1
I feel like you reinvent the wheel. IMHO ramstage should be patched to reduce the steps performed instead of bloating the postcar stage. postcar should be as minimal as possible and only tear down car.
Hello Patrick Rudolph, ron minnich, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32618
to look at the new patch set (#8).
Change subject: Kconfig: Create RAMPAYLOAD kconfig ......................................................................
Kconfig: Create RAMPAYLOAD kconfig
This patch enables coreboot flow to skip ramstage as individual stage to load payload. Instead it is expected to load payload from postcar stage.
Change-Id: I839f2d34a93b69ca6bf3de6594e2ad9f66ee7135 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/Kconfig 1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/32618/8
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32618 )
Change subject: Kconfig: Create RAMPAYLOAD kconfig ......................................................................
Patch Set 8:
The RAMPAYLOAD name is my fault. I still prefer it over these other names, but I'm not that concerned about it. If you all prefer those other names I'm fine with that. Sorry Subrata for adding to the churn.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32618 )
Change subject: Kconfig: Create RAMPAYLOAD kconfig ......................................................................
Patch Set 8:
The RAMPAYLOAD name is my fault. I still prefer it over these other names, but I'm not that concerned about it. If you all prefer those other names I'm fine with that. Sorry Subrata for adding to the churn.
it make sense to me as well, where ramstage got replaced with a payload
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32618 )
Change subject: Kconfig: Create RAMPAYLOAD kconfig ......................................................................
Patch Set 8: Code-Review+2
I understand naming can be a very personal thing, but Subrata indicated he's ok with RAMPAYLOAD, I'm good with it and it's easy to change later, so I'm approving this for now. Thanks everyone.
Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32618 )
Change subject: Kconfig: Create RAMPAYLOAD kconfig ......................................................................
Kconfig: Create RAMPAYLOAD kconfig
This patch enables coreboot flow to skip ramstage as individual stage to load payload. Instead it is expected to load payload from postcar stage.
Change-Id: I839f2d34a93b69ca6bf3de6594e2ad9f66ee7135 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32618 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: ron minnich rminnich@gmail.com --- M src/Kconfig 1 file changed, 15 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified ron minnich: Looks good to me, approved
diff --git a/src/Kconfig b/src/Kconfig index b4898bd..2c9dc4a 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -277,6 +277,21 @@ The path and filename of the file to use as graphical bootsplash screen. The file format has to be jpg.
+config RAMPAYLOAD + bool "Enable coreboot flow without executing ramstage" + default n + depends on ARCH_X86 + help + If this option is enabled, coreboot flow will skip ramstage + loading and execution of ramstage to load payload. + + Instead it is expected to load payload from postcar stage itself. + + In this flow coreboot will perform basic x86 initialization + (DRAM resource allocation), MTRR programming, + Skip PCI enumeration logic and only allocate BAR for fixed devices + (bootable devices, TPM over GSPI). + endmenu
menu "Mainboard"
-
Julius Werner (Code Review) -
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)
-
ron minnich (Code Review)
-
Subrata Banik (Code Review)