Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74290 )
Change subject: Revert "cbfstool/default-x86.fmd: Rename BIOS -> SI_BIOS" ......................................................................
Revert "cbfstool/default-x86.fmd: Rename BIOS -> SI_BIOS"
This reverts commit 89b4f69746ac215e4a7c5f204d1ea807b4ea08b5.
SI_BIOS is mostly used to indicate the BIOS region in Intel IFD. Not all platforms are Intel platforms with an IFD, so revert this change. Also tooling often depends on names not changing so renaming things should not be done lightly. The default region should also be in sync with non-x86 and made systematic across the tree.
Change-Id: I46f52494498295ba5e2a23d0b66b56f266293050 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/74290 Reviewed-by: Lean Sheng Tan sheng.tan@9elements.com Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Maximilian Brune maximilian.brune@9elements.com Reviewed-by: Matt DeVillier matt.devillier@gmail.com Reviewed-by: Paul Menzel paulepanter@mailbox.org --- M util/cbfstool/default-x86.fmd 1 file changed, 27 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Paul Menzel: Looks good to me, approved Matt DeVillier: Looks good to me, approved Felix Singer: Looks good to me, approved Lean Sheng Tan: Looks good to me, approved Maximilian Brune: Looks good to me, but someone else must approve
diff --git a/util/cbfstool/default-x86.fmd b/util/cbfstool/default-x86.fmd index 8991a81..41be782 100644 --- a/util/cbfstool/default-x86.fmd +++ b/util/cbfstool/default-x86.fmd @@ -8,7 +8,7 @@ # +-------------+ <-- 4GB / end of flash
FLASH@##ROM_BASE## ##ROM_SIZE## { - SI_BIOS@##BIOS_BASE## ##BIOS_SIZE## { + BIOS@##BIOS_BASE## ##BIOS_SIZE## { ##CONSOLE_ENTRY## ##MRC_CACHE_ENTRY## ##SMMSTORE_ENTRY##