Change in coreboot[master]: cpu/intel/microcode: Reuse existing function to read MCU revision - coreboot-gerrit

29 Jan 2021


      Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49839 )
Change subject: cpu/intel/microcode: Reuse existing function to read MCU revision
......................................................................
Patch Set 2:
(1 comment)
File src/cpu/intel/microcode/microcode.c:
https://review.coreboot.org/c/coreboot/+/49839/comment/2fcfb8d1_e359e97e 
PS1, Line 133: 	/* CPUID sets MSR 0x8B if a microcode update has been loaded. */
...
does this comment still make sense? Any use of 0x8b is far, far away (even before it was hidden in t […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49839
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If198fa68c0a29f46906151e667d7b00e2a3ab00d
Gerrit-Change-Number: 49839
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 29 Jan 2021 11:04:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com
Gerrit-MessageType: comment