Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48164 )
Change subject: cpu/intel/microcode: Mark assemblycode as 32bit ......................................................................
cpu/intel/microcode: Mark assemblycode as 32bit
Allows to compile the file under x86_64 without errors.
The caller has to make sure to call the functions while in protected mode, which is usually the case in early bootblock.
Change-Id: Ic6d98febb357226183c293c11ba7961f27fac40c Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/cpu/intel/microcode/microcode_asm.S 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/48164/1
diff --git a/src/cpu/intel/microcode/microcode_asm.S b/src/cpu/intel/microcode/microcode_asm.S index f02351a..5173ae5 100644 --- a/src/cpu/intel/microcode/microcode_asm.S +++ b/src/cpu/intel/microcode/microcode_asm.S @@ -43,6 +43,7 @@ * if the revision of the update is newer than what is installed */
+.code32 .section .text .global update_bsp_microcode
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48164 )
Change subject: cpu/intel/microcode: Mark assemblycode as 32bit ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48164 )
Change subject: cpu/intel/microcode: Mark assemblycode as 32bit ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48164/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48164/1//COMMIT_MSG@7 PS1, Line 7: assemblycode nit: assembly code
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48164 )
Change subject: cpu/intel/microcode: Mark assemblycode as 32bit ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48164/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48164/1//COMMIT_MSG@7 PS1, Line 7: assemblycode
nit: assembly code
Done
Patrick Rudolph has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48164 )
Change subject: cpu/intel/microcode: Mark assemblycode as 32bit ......................................................................
cpu/intel/microcode: Mark assemblycode as 32bit
Allows to compile the file under x86_64 without errors.
The caller has to make sure to call the functions while in protected mode, which is usually the case in early bootblock.
Change-Id: Ic6d98febb357226183c293c11ba7961f27fac40c Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48164 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/intel/microcode/microcode_asm.S 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/cpu/intel/microcode/microcode_asm.S b/src/cpu/intel/microcode/microcode_asm.S index f02351a..5173ae5 100644 --- a/src/cpu/intel/microcode/microcode_asm.S +++ b/src/cpu/intel/microcode/microcode_asm.S @@ -43,6 +43,7 @@ * if the revision of the update is newer than what is installed */
+.code32 .section .text .global update_bsp_microcode
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48164 )
Change subject: cpu/intel/microcode: Mark assemblycode as 32bit ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48164/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48164/1//COMMIT_MSG@7 PS1, Line 7: assemblycode
Done
Not done, but it's too late now
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48164 )
Change subject: cpu/intel/microcode: Mark assemblycode as 32bit ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48164/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48164/1//COMMIT_MSG@7 PS1, Line 7: assemblycode
Not done, but it's too late now
Hmm, I've edited the commit on gerrit. Looks like that didn't work.
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Patrick Rudolph (Code Review)