Attention is currently required from: Tarun Tuli, Dinesh Gehlot, Sridhar Siricilla, Arthur Heymans.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74256 )
Change subject: {commonlib, soc/intel/cmn/cse}: Store CSE firmware version into CBMEM ......................................................................
Patch Set 16:
(2 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74256/comment/91995622_defa0ffa PS16, Line 1154: : static void cse_copy_fw_version(struct fw_version *dst, const struct fw_version *src) : { : if (src == NULL || dst == NULL) { : printk(BIOS_WARNING, "CSE: NULL value pointer provided for fw version copy.\n"); : return; : } : : dst->major = src->major; : dst->minor = src->minor; : dst->hotfix = src->hotfix; : dst->build = src->build; : }
Just use memcpy...
Ack
https://review.coreboot.org/c/coreboot/+/74256/comment/92cc0e1f_60b6061e PS16, Line 1262: bool s3wake; : s3wake = acpi_get_sleep_type() == ACPI_S3; : : if (s3wake) : return;
if (acpi_get_sleep_type() == ACPI_S3) […]
Ack